Date: Mon, 06 Jun 2011 11:32:49 +0200 From: Dimitry Andric <dim@FreeBSD.org> To: Hiroki Sato <hrs@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r222732 - in head: sys/netinet usr.sbin/rtadvd usr.sbin/rtsold Message-ID: <4DEC9EC1.9070206@FreeBSD.org> In-Reply-To: <201106060306.p5636hR5008901@svn.freebsd.org> References: <201106060306.p5636hR5008901@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is a multi-part message in MIME format. --------------060203090403090309070709 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2011-06-06 05:06, Hiroki Sato wrote: > Author: hrs > Date: Mon Jun 6 03:06:43 2011 > New Revision: 222732 > URL: http://svn.freebsd.org/changeset/base/222732 > > Log: > - Implement RDNSS and DNSSL options (RFC 6106, IPv6 Router Advertisement > Options for DNS Configuration) into rtadvd(8) and rtsold(8). DNS > information received by rtsold(8) will go to resolv.conf(5) by > resolvconf(8) script. This is based on work by J.R. Oldroyd (kern/156259) > but revised extensively[1]. > > - rtadvd(8) now supports "noifprefix" to disable gathering on-link prefixes > from interfaces when no "addr" is specified[2]. An entry in rtadvd.conf > with "noifprefix" + no "addr" generates an RA message with no prefix > information option. > > - rtadvd(8) now supports RTM_IFANNOUNCE message to fix crashes when an > interface is added or removed. > > - Correct bogus ND_OPT_ROUTE_INFO value to one in RFC 4191. ... > Modified: head/usr.sbin/rtadvd/Makefile > ============================================================================== > --- head/usr.sbin/rtadvd/Makefile Mon Jun 6 02:46:22 2011 (r222731) > +++ head/usr.sbin/rtadvd/Makefile Mon Jun 6 03:06:43 2011 (r222732) > @@ -23,6 +23,6 @@ LDADD= -lutil > > CFLAGS+= -DHAVE_ARC4RANDOM -DHAVE_POLL_H -DROUTEINFO > > -WARNS?= 1 > +WARNS?= 6 Hi, This code is not yet WARNS=6 clean, at least not on amd64: cc1: warnings being treated as errors /usr/src/usr.sbin/rtadvd/rtadvd.c: In function 'rtadvd_input': /usr/src/usr.sbin/rtadvd/rtadvd.c:793: warning: format '%d' expects type 'int', but argument 4 has type 'ssize_t' /usr/src/usr.sbin/rtadvd/rtadvd.c:834: warning: format '%d' expects type 'int', but argument 6 has type 'ssize_t' /usr/src/usr.sbin/rtadvd/rtadvd.c:880: warning: format '%d' expects type 'int', but argument 6 has type 'ssize_t' *** Error code 1 (continuing) cc1: warnings being treated as errors /usr/src/usr.sbin/rtadvd/config.c: In function 'dname_labelenc': /usr/src/usr.sbin/rtadvd/config.c:112: warning: format '%d' expects type 'int', but argument 4 has type 'long int' *** Error code 1 (continuing) `all' not remade because of errors. 1 error Please apply the attached patch, which fixes the warnings. --------------060203090403090309070709 Content-Type: text/plain; name="rtadvd-fmt-1.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="rtadvd-fmt-1.diff" SW5kZXg6IHVzci5zYmluL3J0YWR2ZC9jb25maWcuYwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSB1c3Iu c2Jpbi9ydGFkdmQvY29uZmlnLmMJKHJldmlzaW9uIDIyMjczNykKKysrIHVzci5zYmluL3J0 YWR2ZC9jb25maWcuYwkod29ya2luZyBjb3B5KQpAQCAtMTA5LDcgKzEwOSw3IEBAIGRuYW1l X2xhYmVsZW5jKGNoYXIgKmRzdCwgY29uc3QgY2hhciAqc3JjKQogCS8qIEFsd2F5cyBuZWVk IGEgMC1sZW5ndGggbGFiZWwgYXQgdGhlIHRhaWwuICovCiAJKmRzdCsrID0gJ1wwJzsKIAot CXN5c2xvZyhMT0dfREVCVUcsICI8JXM+IGxhYmVsbGVuID0gJWQiLCBfX2Z1bmNfXywgZHN0 IC0gZHN0X29yaWdpbik7CisJc3lzbG9nKExPR19ERUJVRywgIjwlcz4gbGFiZWxsZW4gPSAl dGQiLCBfX2Z1bmNfXywgZHN0IC0gZHN0X29yaWdpbik7CiAJcmV0dXJuIChkc3QgLSBkc3Rf b3JpZ2luKTsKIH0KIApJbmRleDogdXNyLnNiaW4vcnRhZHZkL2R1bXAuYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSB1c3Iuc2Jpbi9ydGFkdmQvZHVtcC5jCShyZXZpc2lvbiAyMjI3MzcpCisrKyB1 c3Iuc2Jpbi9ydGFkdmQvZHVtcC5jCSh3b3JraW5nIGNvcHkpCkBAIC0zMTAsNyArMzEwLDcg QEAgZG5hbWVfbGFiZWxkZWMoY2hhciAqZHN0LCBzaXplX3QgZGxlbiwgY29uc3QgY2hhcgog CSAgICAoc3JjICsgbGVuKSA8PSBzcmNfbGFzdCkgewogCQlpZiAoZHN0ICE9IGRzdF9vcmln aW4pCiAJCQkqZHN0KysgPSAnLic7Ci0JCXN5c2xvZyhMT0dfREVCVUcsICI8JXM+IGxhYmVs bGVuID0gJWQiLCBfX2Z1bmNfXywgbGVuKTsKKwkJc3lzbG9nKExPR19ERUJVRywgIjwlcz4g bGFiZWxsZW4gPSAlemQiLCBfX2Z1bmNfXywgbGVuKTsKIAkJbWVtY3B5KGRzdCwgc3JjLCBs ZW4pOwogCQlzcmMgKz0gbGVuOwogCQlkc3QgKz0gbGVuOwpJbmRleDogdXNyLnNiaW4vcnRh ZHZkL3J0YWR2ZC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIHVzci5zYmluL3J0YWR2ZC9ydGFkdmQu YwkocmV2aXNpb24gMjIyNzM3KQorKysgdXNyLnNiaW4vcnRhZHZkL3J0YWR2ZC5jCSh3b3Jr aW5nIGNvcHkpCkBAIC03ODksNyArNzg5LDcgQEAgcnRhZHZkX2lucHV0KHZvaWQpCiAjZWxz ZQogCWlmICgoc2l6ZV90KWkgPCBzaXplb2Yoc3RydWN0IGljbXA2X2hkcikpIHsKIAkJc3lz bG9nKExPR19FUlIsCi0JCSAgICAiPCVzPiBwYWNrZXQgc2l6ZSglZCkgaXMgdG9vIHNob3J0 IiwKKwkJICAgICI8JXM+IHBhY2tldCBzaXplKCV6ZCkgaXMgdG9vIHNob3J0IiwKIAkJICAg IF9fZnVuY19fLCBpKTsKIAkJcmV0dXJuOwogCX0KQEAgLTgyNyw3ICs4MjcsNyBAQCBydGFk dmRfaW5wdXQodm9pZCkKIAkJaWYgKChzaXplX3QpaSA8IHNpemVvZihzdHJ1Y3QgbmRfcm91 dGVyX3NvbGljaXQpKSB7CiAJCQlzeXNsb2coTE9HX05PVElDRSwKIAkJCSAgICAiPCVzPiBS UyBmcm9tICVzIG9uICVzIGRvZXMgbm90IGhhdmUgZW5vdWdoICIKLQkJCSAgICAibGVuZ3Ro IChsZW4gPSAlZCkiLAorCQkJICAgICJsZW5ndGggKGxlbiA9ICV6ZCkiLAogCQkJICAgIF9f ZnVuY19fLAogCQkJICAgIGluZXRfbnRvcChBRl9JTkVUNiwgJnJjdmZyb20uc2luNl9hZGRy LCBudG9wYnVmLAogCQkJICAgIHNpemVvZihudG9wYnVmKSksCkBAIC04NzMsNyArODczLDcg QEAgcnRhZHZkX2lucHV0KHZvaWQpCiAJCWlmICgoc2l6ZV90KWkgPCBzaXplb2Yoc3RydWN0 IG5kX3JvdXRlcl9hZHZlcnQpKSB7CiAJCQlzeXNsb2coTE9HX05PVElDRSwKIAkJCSAgICAi PCVzPiBSQSBmcm9tICVzIG9uICVzIGRvZXMgbm90IGhhdmUgZW5vdWdoICIKLQkJCSAgICAi bGVuZ3RoIChsZW4gPSAlZCkiLAorCQkJICAgICJsZW5ndGggKGxlbiA9ICV6ZCkiLAogCQkJ ICAgIF9fZnVuY19fLAogCQkJICAgIGluZXRfbnRvcChBRl9JTkVUNiwgJnJjdmZyb20uc2lu Nl9hZGRyLCBudG9wYnVmLAogCQkJICAgIHNpemVvZihudG9wYnVmKSksCg== --------------060203090403090309070709--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4DEC9EC1.9070206>