Date: Fri, 2 Nov 2018 09:24:55 -0700 From: "Enji Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Marcin Cieslak <saper@saper.info> Cc: FreeBSD Current <freebsd-current@freebsd.org>, Pedro Giffuni <pfg@freebsd.org> Subject: Re: fix WARNING pid 24503 (uhsoctl): ioctl sign-extension ioctl ffffffff8044692b Message-ID: <F971739B-BB92-4E81-A75C-4B9E69CE216E@gmail.com> In-Reply-To: <nycvar.OFS.7.76.444.1810251135050.5494@z.fncre.vasb> References: <nycvar.OFS.7.76.444.1810251135050.5494@z.fncre.vasb>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_38ACBFFB-D83E-4BC7-A398-9D6E1EDA6BDF
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
charset=us-ascii
FYI!
> On Oct 25, 2018, at 4:38 AM, Marcin Cieslak <saper@saper.info> wrote:
>=20
> The following patch seems to fix the signed ioctl value warnings
> in uhsoctl().
>=20
> The code is the same in the current and stable branches.
>=20
> Marcin
>=20
> Index: usr.sbin/uhsoctl/uhsoctl.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
> --- usr.sbin/uhsoctl/uhsoctl.c (revision 339406)
> +++ usr.sbin/uhsoctl/uhsoctl.c (working copy)
> @@ -360,7 +360,7 @@
>=20
> /* Add/remove IP address from an interface */
> static int
> -ifaddr_ad(int d, const char *ifnam, struct sockaddr *sa, struct =
sockaddr *mask)
> +ifaddr_ad(unsigned long d, const char *ifnam, struct sockaddr *sa, =
struct sockaddr *mask)
> {
> struct ifaliasreq req;
> int fd, error;
--Apple-Mail=_38ACBFFB-D83E-4BC7-A398-9D6E1EDA6BDF
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
filename=signature.asc
Content-Type: application/pgp-signature;
name=signature.asc
Content-Description: Message signed with OpenPGP
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAlvcelcACgkQ9YOpJmkw
hhXAwRAAvSFZUmdF4xyWg72ParYZobPp+7qVarr0JgmI3hSDRnwIiZB45I2XTyQc
e2Hum74BPsRHgnGgqx7DfgCuR7xDewqWuYwyu/VVtr9N6lywFjEjcylH77YHUbQ4
qK8vLRX5xsI/GlTNtvxXdfJTK4AYK4/D2vLLzk3Asmayq/gfnztMiivdeGrpiKvb
A2WrOTJDAZ4XwZ/YrnS/GuYh9CHwUF7vHQXh5emtYz9MZ2nksh7hbv0HCOWU3H8T
HzJ4mOsc8Zcq1oGD9joYG734t+2IO4FMfi0+r4Ttkqesn3DwBxvDY8vBgKZjPutO
zGNNrcATQiYLbIrsgmNeRkuq/skdTuzXBXbm+XGbjnTcynsKKJN0fhxvRJooxYDc
qMyKQydRwIMiLv93Ip4eAOHdNJ3v0s02YG/McyYaLL6mE45n+c8OQiC4J20YDd51
So+NvgWOmTCXtzQ+gQMMbzbxBuGFHxfcklECKopOinXbpYKi7olMqV3L6CrKo84L
hxlD+CugPEWe9PabXwJzKCrgP7OzB4ayk3xt7n+Lf+dGkMY1X62Xq4Py+AeuGQF1
VDBrvcdUXhFzCCDmJfioW8BeltPPql64+gfMF5eKOTDowS9Lbqf9iVNmtSsPLLc8
t58ct9usXUz1KHa7ilOYrOG7PaFmYcXEaxh5RnrtfkcK7AGUfxg=
=nIw1
-----END PGP SIGNATURE-----
--Apple-Mail=_38ACBFFB-D83E-4BC7-A398-9D6E1EDA6BDF--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?F971739B-BB92-4E81-A75C-4B9E69CE216E>