Date: Sat, 17 Nov 2018 01:43:41 +0000 From: bugzilla-noreply@freebsd.org To: fs@FreeBSD.org Subject: [Bug 233245] [UFS] [enhancement] Softupdates fails to track dependency between appended data and i_size Message-ID: <bug-233245-3630-iBUHwz9nQq@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-233245-3630@https.bugs.freebsd.org/bugzilla/> References: <bug-233245-3630@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D233245 --- Comment #6 from Kirk McKusick <mckusick@FreeBSD.org> --- (In reply to Conrad Meyer from comment #5) > I would be happy to assign it to myself to take it off the fs@ list, if t= hat > seems most reasonable to everybody. I have no objection to it being on the fs@ list. That way I see any dialog = that happens on it. But if you decide to take it off the fs@ list, then please a= dd me explicitly. > Do you know of any additional good resources I can read for the specific > dependency graph behavior / rollback semantics of SU? I have the FreeBSD > D&I 2e book of course, and the source code is the final word. But if you > have any additional references you can share, I would appreciate it. In about 2000 I used the `special topics' lecture of my advanced code readi= ng class to do a walk-through of the soft updates code. It is a 2.5 hour video= of me going through softdep.h and ffs_softdep.c. It predates the addition of t= he journaling support, so reflects a simpler time, but is probably still usefu= l to get a general understanding. I would be willing to make the video available= to you if you want to watch it. > (Tangential to this enhancement, I might take a pass cleaning up the plain > English of the ffs_softdep.c comment blocks. They are thorough, but tend= to > lack visual separation and thus do not scan easily. Additionally, some > references to specific objects are quoted, while others are not. It might > help me understand SU better to do a pass making an attempt to help others > understand SU better. :-)) I believe that commenting code is very important and have tried to do a good job of it in the soft updates code. So I strongly encourage you to work to improve it. Often the original author overlooks things that seem obvious to them but in fact are confusing to those that are not intimately familiar wi= th the code. So filling in those gaps is a valuable addition. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-233245-3630-iBUHwz9nQq>