Date: Thu, 13 Oct 2005 20:00:36 GMT From: =?ISO-8859-2?Q?Zahemszky_G=E1bor?= <Gabor@Zahemszky.HU> To: freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/87397: incorrect use of PAPERSIZE make variable in some ports Message-ID: <200510132000.j9DK0asj047870@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR ports/87397; it has been noted by GNATS. From: =?ISO-8859-2?Q?Zahemszky_G=E1bor?= <Gabor@Zahemszky.HU> To: bug-followup@FreeBSD.org, gabor@Zahemszky.HU Cc: Subject: Re: ports/87397: incorrect use of PAPERSIZE make variable in some ports Date: Thu, 13 Oct 2005 21:53:05 +0200 Opps, I've just found, that there are some other ports with paper size settings. math/R: it has a LETTER_PAPER option, and the next piece of code: .if defined(WITH_LETTER_PAPER) CONFIGURE_ENV+= R_PAPERSIZE=letter .endif I think, it would be better to use the "global" PAPERSIZE variable as in: .if ( defined( PAPERSIZE ) && ( ${PAPERSIZE} == "letter" ) || ( ${PAPERSIZE} == "letterdj" ) ) CONFIGURE_ENV+= R_PAPERSIZE=letter .endif There are another ports: teTeX, dvipsk-tetex and xdvik with this: .if defined(WITH_LETTERSIZE) FLAVOR+= letter DEPENDS_ARGS+= WITH_LETTERSIZE=true PAPERSIZE= letter .else PAPERSIZE= a4 .endif It may use this form: .if ( defined( PAPERSIZE ) && ( ${PAPERSIZE} == "letter" || ${PAPERSIZE} == "letterdj" ) ) FLAVOR+= letter DEPENDS_ARGS+= WITH_LETTERSIZE=true PAPERSIZE= letter .else PAPERSIZE= a4 .endif by, Gabor -- #!/bin/ksh Z='21N16I25C25E30, 40M30E33E25T15U!';IFS=' ABCDEFGHIJKLMNOPQRSTUVWXYZ ';set -- $Z;for i;{ [[ $i = ? ]]&&print $i&&break;[[ $i = ??? ]]&&j=$i&&i=${i%?};typeset -i40 i=8#$i;print -n ${i#???};[[ "$j" = ??? ]]&&print -n "${j#??} "&&j=;typeset +i i;};IFS=' 0123456789 ';set -- $Z;for i;{ [[ $i = , ]]&&i=2;[[ $i = ?? ]]||typeset -l i;j="$j $i";typeset +l i;};print "$j"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200510132000.j9DK0asj047870>