Date: Sat, 13 Mar 2010 20:57:02 -0800 From: Doug Barton <dougb@FreeBSD.org> To: Wesley Shields <wxs@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Bernhard Froehlich <decke@bluelife.at>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/www/redmine Makefile ports/www/redmine/files redmine.in Message-ID: <4B9C6C9E.3070902@FreeBSD.org> In-Reply-To: <201003140407.o2E47fhJ063684@repoman.freebsd.org> References: <201003140407.o2E47fhJ063684@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 03/13/10 20:07, Wesley Shields wrote: > wxs 2010-03-14 04:07:41 UTC > > FreeBSD ports repository > > Modified files: > www/redmine Makefile > Added files: > www/redmine/files redmine.in > Log: > - Add RC script. > > PR: ports/144299 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=144299 > Submitted by: Bernhard Froehlich <decke@bluelife.at> (maintainer) > > Revision Changes Path > 1.8 +6 -0 ports/www/redmine/Makefile > 1.1 +32 -0 ports/www/redmine/files/redmine.in (new) > > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/Makefile.diff?&r1=1.7&r2=1.8&f=h > http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/redmine/files/redmine.in There are several problems with this script. 1. The REQUIRE line needs to be changed to LOGIN. This is preferred for all local scripts, but mandatory for those which run with a non-root [ug]id (which this one does). 2. Instead of command=%%RUBY_NAME%% it's likely you want to use command_interpreter instead. Does the stop command work with this script as it is currently? 3. _flags should not be included in command_args, it will result in them being included twice. 4. Are all of the options included in _flags actually things that a user might wish to twiddle? Should some of them be in command_args instead? 5. The pidfile location looks dubious to me, but I'm not sure if putting pid files in WWWDIR has somehow become routine? 6. And finally a minor issue, %%RC_SUBR%% should just be /etc/rc.subr. I'll be making that change for all ports once the ports freeze is over, so no reason not to do it now. Doug -- ... and that's just a little bit of history repeating. -- Propellerheads Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B9C6C9E.3070902>