Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 29 Dec 2017 14:35:22 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Luca Pizzamiglio <pizzamig@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r457507 - head/science/lamprop
Message-ID:  <20171229143522.GA39495@FreeBSD.org>
In-Reply-To: <201712291425.vBTEPGj0051945@repo.freebsd.org>
References:  <201712291425.vBTEPGj0051945@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Dec 29, 2017 at 02:25:16PM +0000, Luca Pizzamiglio wrote:
> New Revision: 457507
> URL: https://svnweb.freebsd.org/changeset/ports/457507
> 
> Log:
>   science/lamprop: Update to 3.4
>   
>   PR:		221544
>   Submitted by:	rsmith@xs4all.nl (maintainer)
> 
> Modified: head/science/lamprop/Makefile
> ...
> +PORTVERSION=	3.4
> +CATEGORIES=	science python
> +MASTER_SITES=	GH

What is the point of setting MASTER_SITES now that it was converted to
USE_GITHUB?

>  do-install:
> -	cd ${WRKSRC} && ${MAKE} PREFIX=${STAGEDIR}${PREFIX} install
> +	${INSTALL_SCRIPT} ${WRKSRC}/lamprop ${STAGEDIR}${PREFIX}/bin
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.1 ${STAGEDIR}${MAN1PREFIX}/man/man1
> +	${INSTALL_MAN} ${WRKSRC}/doc/lamprop.5 ${STAGEDIR}${MAN5PREFIX}/man/man5

Since maintainer is apparently also the author, could they be convinced to
provide appropriate `install' target so we don't have to define `do-install'
one in the port?

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171229143522.GA39495>