Date: Fri, 08 Sep 2006 16:34:46 -0400 From: Joe Marcus Clarke <marcus@freebsd.org> To: Jung-uk Kim <jkim@freebsd.org> Cc: Kostik Belousov <kostikbel@gmail.com>, cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/libexec/rtld-elf rtld.c Message-ID: <4501D3E6.20906@freebsd.org> In-Reply-To: <200609081414.27800.jkim@FreeBSD.org> References: <200609081459.k88ExtSR084500@repoman.freebsd.org> <200609081309.29850.jkim@FreeBSD.org> <20060908172232.GG14781@deviant.kiev.zoral.com.ua> <200609081414.27800.jkim@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Jung-uk Kim wrote: > On Friday 08 September 2006 01:22 pm, Kostik Belousov wrote: >> On Fri, Sep 08, 2006 at 01:09:24PM -0400, Jung-uk Kim wrote: >>> On Friday 08 September 2006 10:59 am, Konstantin Belousov wrote: >>>> kib 2006-09-08 14:59:55 UTC >>>> >>>> FreeBSD src repository >>>> >>>> Modified files: >>>> libexec/rtld-elf rtld.c >>>> Log: >>>> When looking up the symbol by dlsym, look it not only in the >>>> object given as dso handle, but also in the implicit >>>> dependencies of that dso. >>>> >>>> Also, const-ify the read-only parameter objlist of >>>> symlook_list. >>>> >>>> Reported by: "Simon 'corecode' Schubert" <corecode at fs >>>> ei tum de> Approved by: kan (mentor) >>>> X-MFC-After: 6.2 >>>> >>>> Revision Changes Path >>>> 1.117 +10 -13 src/libexec/rtld-elf/rtld.c >>> I believe this warrants version number change for ports, IMO. >> This change brings rtld behaviour to the standard. Solaris and >> Linux both do this in the right way. Shall we bump >> __FreeBSD_version for such kind of bugfixes ? >> >> BTW, are you aware of ports that rely on old behaviour ? > > OpenOffice.org has been long time victim of this issue. > > http://www.openoffice.org/issues/show_bug.cgi?id=22253 > > The most recent one is: > > http://www.openoffice.org/issues/show_bug.cgi?id=66667 Mozilla is also a "victim." So are GTK+ and gnome-vfs, for that matter. This is a very welcome fix. Joe -- Joe Marcus Clarke FreeBSD GNOME Team :: gnome@FreeBSD.org FreeNode / #freebsd-gnome http://www.FreeBSD.org/gnome
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4501D3E6.20906>