Date: Thu, 21 Oct 2010 18:23:14 +0000 From: Alexander Best <arundel@freebsd.org> To: Garrett Cooper <gcooper@FreeBSD.org> Cc: freebsd-hackers@freebsd.org Subject: Re: a few minor kldstat fixes Message-ID: <20101021182314.GA16569@freebsd.org> In-Reply-To: <AANLkTik0Kow_jsWrZOjv-jK7zkwSJosuuPOgb4ZF3Hkh@mail.gmail.com> References: <20101021174658.GA11107@freebsd.org> <AANLkTik0Kow_jsWrZOjv-jK7zkwSJosuuPOgb4ZF3Hkh@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu Oct 21 10, Garrett Cooper wrote:
> On Thu, Oct 21, 2010 at 10:46 AM, Alexander Best <arundel@freebsd.org> wrote:
> > this patch fixes the following issues:
> >
> > - unbreak 'kldstat -i 999 -v' output
> > - remove an unnecessary set of "{" and "}"
> > - change printfile() to blend into the overall style used in kldstat.c
> > - add a kldstat(8) entry to document the relationship between the "-i" and "-n" flags
>
> Might be better to say that the -i and -n options are mutually
> exclusive in the manpage, and have the args parser parse out those two
> cases and bail if both of them are set.
i don't think the current behavior should be changed. some people might have
something like 'kldstat -i X -n Y' in their scripts expect "-n Y" to override
"-i X", instead of having kldstat fail.
> Thanks!
> -Garrett
--
a13x
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20101021182314.GA16569>