Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 03 Sep 2019 14:06:22 -0000
From:      "Rodney W. Grimes" <freebsd@gndrsh.dnsmgr.net>
To:        Xin LI <delphij@freebsd.org>
Cc:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r345900 - head/sbin/fsck_msdosfs
Message-ID:  <201904050449.x354nUEC036896@gndrsh.dnsmgr.net>
In-Reply-To: <201904050221.x352LGjU015040@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
> Author: delphij
> Date: Fri Apr  5 02:21:16 2019
> New Revision: 345900
> URL: https://svnweb.freebsd.org/changeset/base/345900
> 
> Log:
>   Implement checking of `.' and `..' entries of subdirectory.
>   
>   Reviewed by:		pfg
>   Obtained from:		Android https://android.googlesource.com/platform/external/fsck_msdos/+/b6ee08aadb580341a4d80943741b80de16a88b5d%5E%21/
>   MFC after:		2 weeks
>   Differential Revision:	https://reviews.freebsd.org/D19824
> 
> Modified:
>   head/sbin/fsck_msdosfs/dir.c
> 
> Modified: head/sbin/fsck_msdosfs/dir.c
> ==============================================================================
> --- head/sbin/fsck_msdosfs/dir.c	Fri Apr  5 01:22:30 2019	(r345899)
> +++ head/sbin/fsck_msdosfs/dir.c	Fri Apr  5 02:21:16 2019	(r345900)
> @@ -444,7 +444,78 @@ checksize(struct bootblock *boot, struct fatEntry *fat
>  	return FSOK;
>  }
>  
> +static const u_char dot_name[] = {
> +	'.', ' ',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> +static const u_char dotdot_name[] = {
> +	'.', '.',' ',' ',' ',' ',' ',' ',' ',' ',' ' };
> +

Does it make since to encode these as hex or octal constants,
one can not tell that those are different values in an easy
manner.  They all look like '.' in the diff, and probably
in most editors.

>  /*
...

-- 
Rod Grimes                                                 rgrimes@freebsd.org





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201904050449.x354nUEC036896>