Date: Thu, 2 Sep 2004 21:20:23 +0000 (UTC) From: Patrick Guelat <pg@imp.ch> To: Robert Watson <rwatson@freebsd.org> Cc: freebsd-current@freebsd.org Subject: Re: Panic in propagate_priority() [5.3-BETA2] Message-ID: <20040902211406.I19478@murphy.imp.ch> In-Reply-To: <Pine.NEB.3.96L.1040902085519.47283A-100000@fledge.watson.org> References: <Pine.NEB.3.96L.1040902085519.47283A-100000@fledge.watson.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-705649812-1094160023=:19478 Content-Type: TEXT/PLAIN; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 8BIT On Thu, 2 Sep 2004, Robert Watson wrote: >> exclusive sleep mutex rip r=1 (0xc079e70c) locked @ /usr/src53/sys/netinet6/raw_ip.c:255 > > Ah, indeed, there's an incorrect "lock" instead of "unlock" there. Could > you try the attached patch: Thanks. Your patch works like a dream. I looked a that line a dozen times and didn't realize it was a lock instead of an unlock ;-) I was just wondering why you're using the same lock in IPv4 and IPv6 and if this probably may cause problems in ipv6 over ipv4 situations. Tested on RELENG_5 -Patrick > > Index: raw_ip6.c > =================================================================== > RCS file: /data/fbsd-cvs/ncvs/src/sys/netinet6/raw_ip6.c,v > retrieving revision 1.45 > diff -u -r1.45 raw_ip6.c > --- raw_ip6.c 12 Aug 2004 18:31:36 -0000 1.45 > +++ raw_ip6.c 2 Sep 2004 12:55:19 -0000 > @@ -252,7 +252,7 @@ > } > ip6stat.ip6s_delivered--; > } > - INP_INFO_RLOCK(&ripcbinfo); > + INP_INFO_RUNLOCK(&ripcbinfo); > return IPPROTO_DONE; > } -- Patrick Guélat, ImproWare AG Network Services, CH-4133 Pratteln Mail: Patrick.Guelat@imp.ch - Phone: +41 61 826 93 00 (ext: 13) --0-705649812-1094160023=:19478--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20040902211406.I19478>