Date: Tue, 11 Oct 2011 13:26:26 +0200 From: Giovanni Trematerra <giovanni.trematerra@gmail.com> To: Christian Brueffer <brueffer@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r226247 - head/sys/compat/linux Message-ID: <CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p%2Bw@mail.gmail.com> In-Reply-To: <201110111032.p9BAWNpw011158@svn.freebsd.org> References: <201110111032.p9BAWNpw011158@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Oct 11, 2011 at 12:32 PM, Christian Brueffer <brueffer@freebsd.org> wrote: > Author: brueffer > Date: Tue Oct 11 10:32:23 2011 > New Revision: 226247 > URL: http://svn.freebsd.org/changeset/base/226247 > > Log: > =A0Properly free linux_gidset in case of an error. > > =A0CID: =A0 =A0 =A0 =A0 =A04136 > =A0Found with: =A0 Coverity Prevent(tm) > =A0MFC after: =A0 =A01 week > > Modified: > =A0head/sys/compat/linux/linux_uid16.c > > Modified: head/sys/compat/linux/linux_uid16.c > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/sys/compat/linux/linux_uid16.c Tue Oct 11 07:46:45 2011 =A0 =A0 = =A0 =A0(r226246) > +++ head/sys/compat/linux/linux_uid16.c Tue Oct 11 10:32:23 2011 =A0 =A0 = =A0 =A0(r226247) > @@ -114,6 +114,7 @@ linux_setgroups16(struct thread *td, str > =A0 =A0 =A0 =A0linux_gidset =3D malloc(ngrp * sizeof(*linux_gidset), M_TE= MP, M_WAITOK); > =A0 =A0 =A0 =A0error =3D copyin(args->gidset, linux_gidset, ngrp * sizeof= (l_gid16_t)); > =A0 =A0 =A0 =A0if (error) > + =A0 =A0 =A0 =A0 =A0 =A0 =A0 free(linux_gidset, M_TEMP); > =A0 =A0 =A0 =A0 =A0 =A0 =A0 =A0return (error); > =A0 =A0 =A0 =A0newcred =3D crget(); > =A0 =A0 =A0 =A0p =3D td->td_proc; Did you miss { } ? -- Gianni
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CACfq091nqG9wOoiOKNmdKfwBuBeyFUff7kUFXNEKqyfWAp6p%2Bw>