Date: Tue, 15 May 2007 13:21:41 +0100 (BST) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern uipc_debug.c uipc_sockbuf.c uipc_socket.c uipc_syscalls.c src/sys/netinet sctputil.c src/sys/sys socketvar.h Message-ID: <20070515131403.E69080@fledge.watson.org> In-Reply-To: <200705031442.l43Egggi064069@repoman.freebsd.org> References: <200705031442.l43Egggi064069@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 3 May 2007, Robert Watson wrote:
> sblock() implements a sleep lock by interlocking SB_WANT and SB_LOCK flags
> on each socket buffer with the socket buffer's mutex. This sleep lock is
> used to serialize I/O on sockets in order to prevent I/O interlacing.
>
> This change replaces the custom sleep lock with an sx(9) lock, which
> results in marginally better performance, better handling of contention
> during simultaneous socket I/O across multiple threads, and a cleaner
> separation between the different layers of locking in socket buffers.
> Specifically, the socket buffer mutex is now solely responsible for
> serializing simultaneous operation on the socket buffer data structure,
> and not for I/O serialization.
>
> While here, fix two historic bugs:
>
> (1) a bug allowing I/O to be occasionally interlaced during long I/O
> operations (discovere by Isilon).
>
> (2) a bug in which failed non-blocking acquisition of the socket buffer
> I/O serialization lock might be ignored (discovered by sam).
>
> SCTP portion of this patch submitted by rrs.
Just an update on this change:
(1) Kris has confirmed 10% performance improvements in MySQL and pgsql on his
test configuration.
(2) Fixes for the signal issue reported by Alfred are available, and I'm
currently waiting for John to review Attilio's sx_.*_sig() patch before I
can commit them.
Robert N M Watson
Computer Laboratory
University of Cambridge
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070515131403.E69080>