Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 25 Sep 2021 12:24:41 -0400
From:      Shawn Webb <shawn.webb@hardenedbsd.org>
To:        Kyle Evans <kevans@freebsd.org>
Cc:        Konstantin Belousov <kib@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org
Subject:   Re: git: 24a3897c2c32 - main - x86 bounce_bus_dmamem_alloc(): use malloc_aligned() only when possible
Message-ID:  <20210925162441.jidijkgso3x6udxm@mutt-hbsd>
In-Reply-To: <CACNAnaGOmE-O6REwxnrMW0DJ_FS1oghskpq76h5i49WOjYrrQQ@mail.gmail.com>
References:  <202109251311.18PDBVqf077216@gitrepo.freebsd.org> <20210925131801.b4lyozg7b56646x4@mutt-hbsd> <CACNAnaGOmE-O6REwxnrMW0DJ_FS1oghskpq76h5i49WOjYrrQQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help

--6qgzcylfpocqbcmk
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Sep 25, 2021 at 10:55:28AM -0500, Kyle Evans wrote:
> On Sat, Sep 25, 2021 at 8:18 AM Shawn Webb <shawn.webb@hardenedbsd.org> w=
rote:
> >
> > On Sat, Sep 25, 2021 at 01:11:31PM +0000, Konstantin Belousov wrote:
> > > The branch main has been updated by kib:
> > >
> > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D24a3897c2c3205c2ec0cf3=
23c555c403d3171e2c
> > >
> > > commit 24a3897c2c3205c2ec0cf323c555c403d3171e2c
> > > Author:     Konstantin Belousov <kib@FreeBSD.org>
> > > AuthorDate: 2021-09-24 17:46:47 +0000
> > > Commit:     Konstantin Belousov <kib@FreeBSD.org>
> > > CommitDate: 2021-09-25 12:58:12 +0000
> > >
> > >     x86 bounce_bus_dmamem_alloc(): use malloc_aligned() only when pos=
sible
> > >
> > >     malloc_domainset_aligned() requires that alignment is less than
> > >     page size. Fall back to other allocation methods, most likely
> > >     kmem_alloc_contig(), when malloc_aligned() cannot fullfill the dr=
iver
> > >     request.
> > >
> > >     Reported by:    Loic F <loic.f@hardenedbsd.org>
> > >     Reviewed by:    markj
> > >     Sponsored by:   The FreeBSD Foundation
> > >     MFC after:      1 week
> > >     Differential revision:  https://reviews.freebsd.org/D32127
> >
> > Wrong Differential revision URL? The patch in the URL doesn't match
> > what was committed here.
> >
>=20
> No; there were two patches included, and Phabricator always updates
> the diff to the first one that closed it. You can check the history on
> the diff to find the last one pre-commit.

Cool. Thanks for the clarification!

--=20
Shawn Webb
Cofounder / Security Engineer
HardenedBSD

https://git.hardenedbsd.org/hardenedbsd/pubkeys/-/raw/master/Shawn_Webb/03A=
4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc

--6qgzcylfpocqbcmk
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEA6TL67gupaZ9nzhT/y5nonf44foFAmFPTUcACgkQ/y5nonf4
4fo++Q//bu+bYu+KfmnQA1P9EMSaP9rke530/rHUPZSob/K7Z8D0qhvF7hCrS0cP
qk/Em5AL0+ATLiZccTsoLL2Hc4YZZgKeZXI+pUzDu654ZH7zcWtYH2Upt2KlxYqH
35nV9t9M87D4eO0x8T7T8TK29/YUAiHXiQ79S2JFTimJLKM6gkEGXszSJKph+Pas
Q9gxn06l6+bbYkU3cQ+YCVV2SXe+9Tp6ibNR32PF3d867NAcW7nHubdW/2tMIONe
Tfvc7CkY7kNd3ffPjS8mW0sAgGt2vRJTqplPoiYkYfkmXYnYvesjCiQB1HlsUVxQ
wpxxqRyZ6hf9AW0EdGappfM93QLhE8xF27y3jZwWSo8VDjBB5nFjx9Mhrnzk4edB
tqVNtU+C04b3CdX4rDLSyePBj0jA3Gi7bbtB4vPlTI/qYsJidcmAN+JBbesEtHWc
tGYSXm4YawtigsS99EI6aAmUomnI2DaKx8qsbx8hOyFnBu4uacYhX9BzANBW0/lp
ZP0Sufy7c3GGxwWLpyiDX/cUl/kMlu29Dr+gzNmPjf/QH8yTAmd86snAmHPJi0tj
fnd9Md2HGUhY2DFmmnz+WJOCT37Xzpcx9bwzU6KZzCp7b5USIH/ATcCoj3LD+5Ph
/I3goz+6ISiA05QRyBo49r+sCCm5nW1NZT+f7xfBrYfqimrqr8Q=
=1Q2t
-----END PGP SIGNATURE-----

--6qgzcylfpocqbcmk--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20210925162441.jidijkgso3x6udxm>