Date: Wed, 31 Dec 2003 14:23:22 -0500 (EST) From: Robert Watson <rwatson@FreeBSD.org> To: John Baldwin <jhb@FreeBSD.org> Cc: William Michael Grim <wgrim@siue.edu> Subject: Re: pciconf -lv - /dev/pci error Message-ID: <Pine.NEB.3.96L.1031231141605.54208B-100000@fledge.watson.org> In-Reply-To: <XFMail.20031231140204.jhb@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 31 Dec 2003, John Baldwin wrote: > History is in PR 32677. I do think your patch might be ok if it only > applies to the -l case. If so, then it should probably be committed and > MFC'd (along with the kernel pci_user.c change) so the PR can be closed. Well, this patch changes only the user code for pciconf, which doesn't run with privilege, not the kernel code implementing the protections. pciconf appears only to require the PCIOCGETCONF ioctl to implement -l[v], and all this patch does is make it so pciconf ask for a read-only file descriptor for -l[v]. This patch doesn't fix pciconf with securelevels, since we still prevent acquiring an open file descriptor when the securelevel is > 0. I think a better answer would be to expose the PCI stuff using a sysctl mib rather than an ioctl, since file descriptors to /dev/pci are multi-purpose, and imply the ability to read/write the register space, etc. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Senior Research Scientist, McAfee Research
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.NEB.3.96L.1031231141605.54208B-100000>