Date: Mon, 21 Jun 2021 22:56:38 +0100 From: Jessica Clarke <jrtc27@freebsd.org> To: Dmitry Chagin <dchagin@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: e013e36939ac - main - linux(4): Get rid of Linuxulator kernel build options. Message-ID: <C06B43AE-D887-410F-A212-5A16BC28DDB7@freebsd.org> In-Reply-To: <202106211656.15LGuXQU059224@gitrepo.freebsd.org> References: <202106211656.15LGuXQU059224@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 21 Jun 2021, at 17:56, Dmitry Chagin <dchagin@FreeBSD.org> wrote: >=20 > The branch main has been updated by dchagin: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3De013e36939ac87b53195370fb5e29f29= c1a4b5c6 >=20 > commit e013e36939ac87b53195370fb5e29f29c1a4b5c6 > Author: Dmitry Chagin <dchagin@FreeBSD.org> > AuthorDate: 2021-06-22 05:32:39 +0000 > Commit: Dmitry Chagin <dchagin@FreeBSD.org> > CommitDate: 2021-06-22 05:32:39 +0000 >=20 > linux(4): Get rid of Linuxulator kernel build options. >=20 > Stop confusing people, retire COMPAT_LINUX and COMPAT_LINUX32 = kernel > build options. Since we have 32 and 64 bit Linux emulators, we = can't build both > emulators together into the kernel. I don't think it matters, Linux = emulation > depends on loadable modules (via rc). >=20 > Cut LINPROCFS and LINSYSFS for consistency. I don=E2=80=99t see why these two should be deleted? They currently = build fine, and GNU/kFreeBSD kernels enable them. They might work as modules, but I would worry that too many parts of userland would try and read them before /etc/init.d/kldutils (the init script that loads modules) loads them, so then we=E2=80=99d have to mess around with GRUB configs to = preload them. If the options work, please leave them in. There=E2=80=99s a separate debate of whether this is the =E2=80=9Cright=E2= =80=9D fix for COMPAT_LINUX*; arguably that *should* work and it=E2=80=99s a bug that = they don=E2=80=99t, not a feature, even if it=E2=80=99s not of much interest = to support=E2=80=A6 I=E2=80=99d like to see the second half reverted, please, and believe = the first should be too, but I feel less strongly about that. Jess
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?C06B43AE-D887-410F-A212-5A16BC28DDB7>