Date: Sat, 9 Dec 2006 20:58:26 +0000 (UTC) From: Shteryana Shopova <syrinx@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c bridge_if.c bridge_port.c Message-ID: <200612092058.kB9KwQcI077387@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
syrinx 2006-12-09 20:58:26 UTC
FreeBSD src repository
Modified files:
usr.sbin/bsnmpd/modules/snmp_bridge bridge_addrs.c bridge_if.c
bridge_port.c
Log:
Instead of explicitly initializing variables to avoid compiler warnings,
add a default case to handle the situation when the variables are not
initialized.
Furthermore, abort() if the snmp agent passes an invalid option to the
bridge module. As the option (SET, GET, GETNEXT, COMMIT, ROLLBACK) is
determined by the snmp agent based on the operation requested by user,
this behaviour is unlikely to be abused as a source for a DoS, but if
ever hit will likely reveal a problem in the snmp agent or bridge
module.
Approved by: bz (mentor)
Revision Changes Path
1.2 +4 -3 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_addrs.c
1.3 +19 -4 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_if.c
1.3 +19 -9 src/usr.sbin/bsnmpd/modules/snmp_bridge/bridge_port.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200612092058.kB9KwQcI077387>