Date: Sat, 3 Jul 2004 19:17:06 +0000 (UTC) From: Robert Watson <rwatson@FreeBSD.org> To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/nfsserver nfs_srvcache.c Message-ID: <200407031917.i63JH6wO095916@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
rwatson 2004-07-03 19:17:06 UTC
FreeBSD src repository
Modified files:
sys/nfsserver nfs_srvcache.c
Log:
Change M_WAITOK argument to sodupsockaddr() to M_NOWAIT. When the call
to dup_sockaddr() was renamed to sodupsockaddr(), the argument was
changed from '1' to 'M_WAITOK', which changed the semantics. This
resulted in a WITNESS warning about a potential sleep while holding the
NFS server mutex. Now this will no longer happen, restoring a possible
bug present in the original code (setting RC_NAM even though the malloc
to copy the addres may fail). bde observes that the flag names here
should probably not be the same as the malloc flags for name space
reasons.
Bumped into by: kuriyama
Revision Changes Path
1.39 +5 -1 src/sys/nfsserver/nfs_srvcache.c
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200407031917.i63JH6wO095916>