Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 15 Apr 2007 01:15:45 +0400
From:      Stanislav Sedov <stas@FreeBSD.org>
To:        "Andrew Pantyukhin" <infofarmer@FreeBSD.org>
Cc:        Stanislav Sedov <stas@freebsd.org>, cvs-ports@freebsd.org, cvs-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: cvs commit: ports/www Makefile ports/www/xpi-vimperator Makefile distinfo pkg-descr
Message-ID:  <20070415011545.d25b8107.stas@FreeBSD.org>
In-Reply-To: <cb5206420704141359g3f7f44f2m4cfb54010369ec34@mail.gmail.com>
References:  <200704142021.l3EKLwT6071007@repoman.freebsd.org> <cb5206420704141359g3f7f44f2m4cfb54010369ec34@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
--Signature=_Sun__15_Apr_2007_01_15_45_+0400_YhfNHMo39_BMTI1Y
Content-Type: text/plain; charset=US-ASCII
Content-Disposition: inline
Content-Transfer-Encoding: 7bit

On Sun, 15 Apr 2007 00:59:17 +0400
"Andrew Pantyukhin" <infofarmer@FreeBSD.org> mentioned:

> On 4/15/07, Stanislav Sedov <stas@freebsd.org> wrote:
> > stas        2007-04-14 20:21:58 UTC
> >
> >   FreeBSD ports repository
> >
> >   Modified files:
> >     www                  Makefile
> >   Added files:
> >     www/xpi-vimperator   Makefile distinfo pkg-descr
> >   Log:
> >   Vimperator is a free browser add-on for Firefox, which makes it look and behave
> >   like the Vim text editor. It has similar key bindings, and you could call it
> >   a modal webbrowser, as key bindings differ according to which mode you are in.
> >
> >   Author: Martin Stubenschrott
> >   WWW:    http://vimperator.mozdev.net/
> >
> >   Revision  Changes    Path
> >   1.1786    +1 -0      ports/www/Makefile
> >   1.1       +23 -0     ports/www/xpi-vimperator/Makefile (new)
> >   1.1       +3 -0      ports/www/xpi-vimperator/distinfo (new)
> >   1.1       +6 -0      ports/www/xpi-vimperator/pkg-descr (new)
>
> This extension is seriously cool. Sent the author
> EUR5 :) Please consider this little patch:
>
> http://people.freebsd.org/~sat/diffs/vimp.diff
>
>

Yeah, i was amazingly glad to discover it:-)

> -MASTER_SITES=  ${MASTER_SITE_MOZDEV}
> -MASTER_SITE_SUBDIR=    ${PORTNAME}
> -DISTNAME=      ${PORTNAME}_${PORTVERSION}
> +MASTER_SITES=  MOZDEV
> +DISTNAME=      ${PORTNAME}_${DISTVERSION}

Hmm. Why use ${DISTVERSION} instead of PORTVERSION? Also I prefer to
use full names for master sites.

Thanks for review.

--
Stanislav Sedov
ST4096-RIPE

--Signature=_Sun__15_Apr_2007_01_15_45_+0400_YhfNHMo39_BMTI1Y
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (FreeBSD)

iD8DBQFGIUSBK/VZk+smlYERAhC7AJ4wFIIKXXSdTzYyMfplSmLgBKYLWgCbB8uA
yDaUYyplMbuAP1e0mawiWas=
=82KV
-----END PGP SIGNATURE-----

--Signature=_Sun__15_Apr_2007_01_15_45_+0400_YhfNHMo39_BMTI1Y--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070415011545.d25b8107.stas>