Skip site navigation (1)Skip section navigation (2)
Date:      Sat, 27 Jun 2026 13:40:10 +0200
From:      =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org>
To:        Siva Mahadevan <siva@FreeBSD.org>
Cc:        src-committers@FreeBSD.org,  dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org
Subject:   Re: git: 5b8c28adb829 - main - ping/tests: expect bell chars from stderr after initial status
Message-ID:  <86bjcwdxet.fsf@ltc.des.dev>
In-Reply-To: <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org> (Siva Mahadevan's message of "Fri, 26 Jun 2026 23:03:16 %2B0000")
References:  <6a3f0534.34ab3.7098834f@gitrepo.freebsd.org>

index | next in thread | previous in thread | raw e-mail

Siva Mahadevan <siva@FreeBSD.org> writes:
> commit 5b8c28adb829b50fb8ac065637fa99f717858bab
> Author:     Siva Mahadevan <siva@FreeBSD.org>
> AuthorDate: 2026-06-26 12:22:57 +0000
> Commit:     Siva Mahadevan <siva@FreeBSD.org>
> CommitDate: 2026-06-26 22:46:09 +0000
>
>     ping/tests: expect bell chars from stderr after initial status
>     
>     After 141bb85798 and 8bda488114f3, ping(8) first writes and flushes the
>     initial status to stdout, then writes notification bell characters to stderr.
>     
>     This patch corrects the expected order of the output to stdout and stderr.
>     This is a temporary fix; the test should be rewritten to separate the output
>     streams and run expectations on each individually.
>     
>     Reviewed by:    des
>     MFC after:      3 days
>     Sponsored by:   The FreeBSD Foundation

The change is correct, but the commit message is not, and reads like a
chatbot.  Please revert and re-commit with a correct human-written log
message.

DES
-- 
Dag-Erling Smørgrav - des@FreeBSD.org


home | help

Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86bjcwdxet.fsf>