Date: Mon, 21 Jul 2014 11:04:38 +0000 From: Alexey Dokuchaev <danfe@FreeBSD.org> To: Guido Falsi <mad@madpilot.net> Cc: gnome@FreeBSD.org Subject: Re: [patch] improvements to www/webkit-gtk2 port Message-ID: <20140721110438.GA47324@FreeBSD.org> In-Reply-To: <53CCF2FA.7050205@madpilot.net> References: <20140721104734.GA36923@FreeBSD.org> <53CCF2FA.7050205@madpilot.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 21, 2014 at 01:01:14PM +0200, Guido Falsi wrote:
> On 07/21/14 12:47, Alexey Dokuchaev wrote:
> > please consider attached patch (this is the first draft; ideally i want to
> > fix both webkit-gtk{2,3} ports at once since they are very similar; maybe
> > even turning them into master/slave pair).
> >
> > - Dependency on devel/gperf from ports seems a leftover from the old days;
> > today both base and ports offer version 3.0.3 (the latest GPLv2 one)
> > - Dependency on textproc/gtk-doc looks bogus; removing and passing option
> > --disable-gtk-doc (just in case) makes no observable changes in the
> > resulting package (no pkg-plist changes unless I'm missing something),
> > so I propose we just remove it (at it pulls some not very nice shit)
> > - Use some convenient option helpers (and CFLAGS_powerpc64)
> > - Remove WEBGL_DESC, it's in the default descriptions pool now
> > - Allow it to be built without GStreamer (but enable it by default)
> > - Correctly detect Clang via USE=compiler and adjust COMMENT while here
> >
> > tinderbuilds went OK, but of course more review/testing is welcome!
>
> Just something I noticed reding the patch:
>
> +USES= bison compiler gettext gmake perl5 pkgconfig tar:xz
> +USE_AUTOTOOLS= libtool
>
> I think this should be
>
> USES= bison compiler gettext gmake libtool perl5 pkgconfig tar:xz
> USE_AUTOTOOLS= libtoolize
I'll merge this change and redo my tinderruns. Thanks for noticing.
./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140721110438.GA47324>