Date: Mon, 7 Jul 2014 16:10:24 +0200 From: Mateusz Guzik <mjguzik@gmail.com> To: Konstantin Belousov <kostikbel@gmail.com> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Mateusz Guzik <mjg@FreeBSD.org> Subject: Re: svn commit: r268087 - head/sys/kern Message-ID: <20140707141024.GA5265@dft-labs.eu> In-Reply-To: <20140707062357.GF93733@kib.kiev.ua> References: <201407010921.s619LXHL063077@svn.freebsd.org> <20140701114245.GO93733@kib.kiev.ua> <20140701115612.GA26696@dft-labs.eu> <20140701123058.GP93733@kib.kiev.ua> <20140701125410.GB26696@dft-labs.eu> <20140701180903.GT93733@kib.kiev.ua> <20140706211850.GA17706@dft-labs.eu> <20140706213900.GB17706@dft-labs.eu> <20140707062357.GF93733@kib.kiev.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Jul 07, 2014 at 09:23:57AM +0300, Konstantin Belousov wrote: > On Sun, Jul 06, 2014 at 11:39:00PM +0200, Mateusz Guzik wrote: > > > That said, I would prefer to just commit previously proposed fixup. > > > > Ok. > Committed as r268365. > > > > hm, I only now notice that fexecve case does: > > vn_lock(binvp, LK_EXCLUSIVE | LK_RETRY) > > > > I guess this can be safely changed to LK_SHARED. > > No, it cannot. The VV_TEXT flag must be handled under the exclusive lock. Allright, not touching this one. Thanks, -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140707141024.GA5265>