Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 20 Apr 2018 15:41:33 +0000 (UTC)
From:      "Jonathan T. Looney" <jtl@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org
Subject:   svn commit: r332828 - stable/11/sys/netinet
Message-ID:  <201804201541.w3KFfXTK096731@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: jtl
Date: Fri Apr 20 15:41:33 2018
New Revision: 332828
URL: https://svnweb.freebsd.org/changeset/base/332828

Log:
  MFC r306768:
    If the new window size is less than the old window size, skip the
    calculations to check if we should advertise a larger window.

Modified:
  stable/11/sys/netinet/tcp_output.c
Directory Properties:
  stable/11/   (props changed)

Modified: stable/11/sys/netinet/tcp_output.c
==============================================================================
--- stable/11/sys/netinet/tcp_output.c	Fri Apr 20 15:35:58 2018	(r332827)
+++ stable/11/sys/netinet/tcp_output.c	Fri Apr 20 15:41:33 2018	(r332828)
@@ -677,10 +677,11 @@ after_sack_rexmit:
 			oldwin = 0;
 
 		/* 
-		 * If the new window size ends up being the same as the old
-		 * size when it is scaled, then don't force a window update.
+		 * If the new window size ends up being the same as or less
+		 * than the old size when it is scaled, then don't force
+		 * a window update.
 		 */
-		if (oldwin >> tp->rcv_scale == (adv + oldwin) >> tp->rcv_scale)
+		if (oldwin >> tp->rcv_scale >= (adv + oldwin) >> tp->rcv_scale)
 			goto dontupdate;
 
 		if (adv >= (long)(2 * tp->t_maxseg) &&



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201804201541.w3KFfXTK096731>