Date: Sun, 23 Feb 2020 03:52:52 +0900 (JST) From: Hiroki Sato <hrs@FreeBSD.org> To: kevans@FreeBSD.org, cem@freebsd.org, antoine@freebsd.org Cc: lwhsu@freebsd.org, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r358152 - head/bin/sh Message-ID: <20200223.035252.1359423210478514412.hrs@FreeBSD.org> In-Reply-To: <CAG6CVpXfjoGmCME0ph87YpfDc=VYQVLpoQ4NpvvajxOb9xSh0A@mail.gmail.com> <CACNAnaGFqOu9qL6p7pKt7FdMQVGsi6dNs%2BiKg1huet27kacCEw@mail.gmail.com> References: <CAALwa8kNAb0ME7v6gqdUPCcc%2BnZ9si0VYk0AveEndmTQfxsQ2g@mail.gmail.com> <CAKBkRUzv%2BkB5W-VBacSp4k6YqWyDyCEKZr1W5vEtajojnAMs9A@mail.gmail.com> <CAG6CVpXfjoGmCME0ph87YpfDc=VYQVLpoQ4NpvvajxOb9xSh0A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)-- Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Conrad Meyer <cem@freebsd.org> wrote in <CAG6CVpXfjoGmCME0ph87YpfDc=VYQVLpoQ4NpvvajxOb9xSh0A@mail.gmail.com>: ce> Given the report and looking at the change, I suspect the problem is ce> the promotion of '-residue' from size_t (unsigned 32-bit on i386) to ce> off_t (signed 64-bit). Something like '-(off_t)residue' or even ce> 'off_t residue;' should fix it. Yes, r358235 is the correct fix. I am sorry for the breakage and thank you for fixing it quickly. -- Hiroki ----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)-- Content-Type: application/pgp-signature Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iMkEABMKAC4WIQRsDSNTJ8+Ax5Ae/dLbsH3Gbx9zfwUCXlF4hBAcaHJzQGZyZWVi c2Qub3JnAAoJENuwfcZvH3N/7GwCCQF9bck/PMytWUxnFUbUK/LQesP36QdPL3lh BIBDMxlXSydCUHe8RaC78j0niIi5CC3ZTAUsRRuw17CXWSezqZvVkAIHbzmSTN6x BVCYenxOjXRe8KUVnYPLv004tIapzJSq7VL/+Ned0f41F5R38BKdtKozjETWJfW8 wCL+D0QaeI1WWHA= =W9aI -----END PGP SIGNATURE----- ----Security_Multipart(Sun_Feb_23_03_52_52_2020_276)----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200223.035252.1359423210478514412.hrs>