Date: Fri, 29 Sep 2023 05:52:06 +0000 From: Alexey Dokuchaev <danfe@freebsd.org> To: Colin Percival <cperciva@freebsd.org> Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 7494fb6b7d80 - main - EC2: Flavour existing AMIs as "base" Message-ID: <ZRZmBtCDrgHpwqEF@FreeBSD.org> In-Reply-To: <202309282218.38SMIqGH056845@gitrepo.freebsd.org> References: <202309282218.38SMIqGH056845@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 28, 2023 at 10:18:52PM +0000, Colin Percival wrote: > commit 7494fb6b7d809257d4eb9eff06ce226143f27add > > EC2: Flavour existing AMIs as "base" I think it should be "flavor" since FreeBSD prefers American spelling. > @@ -31,6 +31,7 @@ BASIC-CI_DESC= Image for CI > EC2_FORMAT= raw > EC2_FSLIST= ufs zfs > EC2_DESC= Amazon EC2 image > +EC2_FLAVOURS= BASE Since other nearby values (format, filesystems) are lowercase, perhaps it makes sense to say EC2_FLAVORS=base and :tu it when needed in the code to keep declarations consistent and tidy. > GCE_FORMAT= raw > GCE_FSLIST= ufs zfs ./danfe
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ZRZmBtCDrgHpwqEF>