Date: Sat, 13 May 2017 10:39:15 -0600 From: Warner Losh <imp@bsdimp.com> To: Ngie Cooper <yaneurabeya@gmail.com> Cc: "Rodney W. Grimes" <rgrimes@freebsd.org>, Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, "svn-src-all@freebsd.org" <svn-src-all@freebsd.org>, "svn-src-head@freebsd.org" <svn-src-head@freebsd.org> Subject: Re: svn commit: r318250 - in head: etc etc/newsyslog.conf.d etc/syslog.d tools/build/mk Message-ID: <CANCZdfpmcfU9YCxgZ%2Bi3AnPW77TPk1MRu2msWJ4t-rPE90SCiw@mail.gmail.com> In-Reply-To: <E92037DB-3739-4BA9-BC96-A50855F19B04@gmail.com> References: <201705131537.v4DFbgWV045290@pdx.rh.CN85.dnsmgr.net> <E6B91EBC-7E7B-4A0B-9807-506A786EDC45@gmail.com> <E92037DB-3739-4BA9-BC96-A50855F19B04@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, May 13, 2017 at 10:32 AM, Ngie Cooper <yaneurabeya@gmail.com> wrote: > >> On May 13, 2017, at 09:29, Ngie Cooper <yaneurabeya@gmail.com> wrote: >> >> On May 13, 2017, at 08:37, Rodney W. Grimes <freebsd@pdx.rh.CN85.dnsmgr.net> wrote: >> >>>> Author: ngie >>>> Date: Sat May 13 03:10:50 2017 >>>> New Revision: 318250 >>>> URL: https://svnweb.freebsd.org/changeset/base/318250 >>>> >>>> Log: >>>> Handle the logfiles in newsyslog and syslogd conditionally, based on >>>> src.conf(5) knobs >>>> >>>> This will allow consumers of FreeBSD to use the unmodified configuration >>>> files out of the box more than previously. >>> >>> What about simply generating proper newsyslog.conf and syslog.conf based >>> on the the MK_ values rather than change the visible administration >>> interface that has finger memory, ansible, and puppet support? >> >> - My employer doesn't use puppet on its appliances. >> - Files snapshotted in time bitrot (which was the case with our configs, which is part of the reason behind this change. couldn't you have an Isilion config file in the appropriate directory instead? And use the default newsyslog / syslog config files? >> - It's really easy to screw up a mergemaster call if you edit the files, and install the stock version which removes the edits. > > Also, programmatically removing the entries means you have to bake the metadata into etc/Makefile, which is already complicated enough as-is. Why do you care about removing them at all? They are no-ops if the files don't exist. Why not just always install all these files is where I'm going with this... Warner
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpmcfU9YCxgZ%2Bi3AnPW77TPk1MRu2msWJ4t-rPE90SCiw>