Date: Sat, 6 Nov 2010 11:22:53 -0700 From: Garrett Cooper <gcooper@FreeBSD.org> To: hackers@freebsd.org Subject: [PATCH] Simplify uart_bus_pci_probe Message-ID: <AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob@mail.gmail.com>
next in thread | raw e-mail | index | archive | help
--0016364c7576bc10170494667abf
Content-Type: text/plain; charset=ISO-8859-1
Some of the logic could have been simplified in the probe. The
proposed patch makes the detection process a tad bit more
straightforward.
Comments, review (and maybe a commit :P) are more than welcome :).
Thanks!
-Garrett
--0016364c7576bc10170494667abf
Content-Type: application/octet-stream;
name="uart-bus-probe-minor-cleanup.patch"
Content-Disposition: attachment; filename="uart-bus-probe-minor-cleanup.patch"
Content-Transfer-Encoding: base64
X-Attachment-Id: f_gg6tkewo0
SW5kZXg6IHN5cy9kZXYvdWFydC91YXJ0X2J1c19wY2kuYwo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzeXMvZGV2
L3VhcnQvdWFydF9idXNfcGNpLmMJKHJldmlzaW9uIDIxNDg1NykKKysrIHN5cy9kZXYvdWFydC91
YXJ0X2J1c19wY2kuYwkod29ya2luZyBjb3B5KQpAQCAtMTUwLDE0ICsxNTAsMTMgQEAKIAlzYyA9
IGRldmljZV9nZXRfc29mdGMoZGV2KTsKIAogCWlkID0gdWFydF9wY2lfbWF0Y2goZGV2LCBwY2lf
bnM4MjUwX2lkcyk7Ci0JaWYgKGlkICE9IE5VTEwpIHsKLQkJc2MtPnNjX2NsYXNzID0gJnVhcnRf
bnM4MjUwX2NsYXNzOwotCQlnb3RvIG1hdGNoOworCWlmIChpZCA9PSBOVUxMKSB7CisJCS8qIEFk
ZCBjaGVja3MgZm9yIG5vbi1uczgyNTAgSURzIGhlcmUuICovCisJCXJldHVybiAoRU5YSU8pOwog
CX0KLQkvKiBBZGQgY2hlY2tzIGZvciBub24tbnM4MjUwIElEcyBoZXJlLiAqLwotCXJldHVybiAo
RU5YSU8pOwogCi0gbWF0Y2g6CisJc2MtPnNjX2NsYXNzID0gJnVhcnRfbnM4MjUwX2NsYXNzOwor
CiAJaWYgKGlkLT5kZXNjKQogCQlkZXZpY2Vfc2V0X2Rlc2MoZGV2LCBpZC0+ZGVzYyk7CiAJcmV0
dXJuICh1YXJ0X2J1c19wcm9iZShkZXYsIDAsIGlkLT5yY2xrLCBpZC0+cmlkLCAwKSk7Cg==
--0016364c7576bc10170494667abf--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?AANLkTimMt4Ucm%2BfRipzk3sq0M=1DNaC6EGQJ8M0ZWwob>