Date: Mon, 27 Jul 2015 16:23:28 +0000 (GMT) From: jenkins-admin@FreeBSD.org To: ed@FreeBSD.org, marius@FreeBSD.org, jenkins-admin@FreeBSD.org, freebsd-current@FreeBSD.org, freebsd-i386@FreeBSD.org Subject: FreeBSD_HEAD_i386 - Build #687 - Fixed Message-ID: <1015674336.31.1438014208527.JavaMail.jenkins@jenkins-9.freebsd.org> In-Reply-To: <1389431495.27.1438006701138.JavaMail.jenkins@jenkins-9.freebsd.org> References: <1389431495.27.1438006701138.JavaMail.jenkins@jenkins-9.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
FreeBSD_HEAD_i386 - Build #687 - Fixed: Build information: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/687/ Full change log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/687/changes Full build log: https://jenkins.FreeBSD.org/job/FreeBSD_HEAD_i386/687/console Change summaries: 285913 by marius: - Fix compilation after r285909 with USB_DEBUG defined. - Regenerate usb.conf. 285912 by marius: - Use __FBSDID(). - Const'ify cons_to_vga_colors. - Fix line wrapping. MFC after: 3 days 285911 by marius: - Nuke dupe $FreeBSD$. - Fix whitespace. MFC after: 3 days 285910 by ed: Make shutdown() return ENOTCONN as required by POSIX, part deux. Summary: Back in 2005, maxim@ attempted to fix shutdown() to return ENOTCONN in case the socket was not connected (r150152). This had to be rolled back (r150155), as it broke some of the existing programs that depend on this behavior. I reapplied this change on my system and indeed, syslogd failed to start up. I fixed this back in February (279016) and MFC'ed it to the supported stable branches. Apart from that, things seem to work out all right. Since at least Linux and Mac OS X do the right thing, I'd like to go ahead and give this another try. To keep old copies of syslogd working, only start returning ENOTCONN for recent binaries. I took a look at the XNU sources and they seem to test against both SS_ISCONNECTED, SS_ISCONNECTING and SS_ISDISCONNECTING, instead of just SS_ISCONNECTED. That seams reasonable, so let's do the same. Test Plan: This issue was uncovered while writing tests for shutdown() in CloudABI: https://github.com/NuxiNL/cloudlibc/blob/master/src/libc/sys/socket/shutdown_test.c#L26 Reviewers: glebius, rwatson, #manpages, gnn, #network Reviewed By: gnn, #network Subscribers: bms, mjg, imp Differential Revision: https://reviews.freebsd.org/D3039
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1015674336.31.1438014208527.JavaMail.jenkins>