Date: Sat, 21 Mar 2009 00:11:39 GMT From: "Scot W. Hetzel" <swhetzel@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/132887: net/samba3: Invalid value for SUB_LIST variable. Message-ID: <200903210011.n2L0BdJF052802@www.freebsd.org> Resent-Message-ID: <200903210020.n2L0K1X6070140@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 132887
>Category: ports
>Synopsis: net/samba3: Invalid value for SUB_LIST variable.
>Confidential: no
>Severity: serious
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Sat Mar 21 00:20:01 UTC 2009
>Closed-Date:
>Last-Modified:
>Originator: Scot W. Hetzel
>Release: 8.0-CURRENT
>Organization:
>Environment:
>Description:
The following code taken from net/samba3*/Makefile. This code has an error:
.if !defined(WITHOUT_WINBIND)
CONFIGURE_ARGS+= --with-winbind
PLIST_SUB+= WINBIND=""
SUB_LIST+= WINBIND=""
.else
CONFIGURE_ARGS+= --without-winbind
PLIST_SUB+= WINBIND="@comment "
SUB_LIST+= WINBIND="@comment "
.endif
The SUB_LIST is being used to replace %%WINBIND%% in ${FILESDIR}/samba.in. When the WINBIND option is off, it cause %%WINBIND%% to be replaced with '@comment ' in the shell script file. Instead it should have replaced %%WINBIND%% with the shell comment character "#" instead.
NOTE: This problem affects all 3 samba ports:
net/samba3
net/samba32
net/samba33
>How-To-Repeat:
Install net/samba3 with the WINBIND option off.
>Fix:
Replace '@comment ' with '#' for the WINBIND SUB_LIST entry.
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200903210011.n2L0BdJF052802>