Date: Sun, 01 Apr 2018 10:44:27 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 227155] [NEW PORT] databases/py-carbonate: Tools for managing federated carbon clusters Message-ID: <bug-227155-13-3e4dN7atVt@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-227155-13@https.bugs.freebsd.org/bugzilla/> References: <bug-227155-13@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D227155 Kubilay Kocak <koobs@FreeBSD.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch --- Comment #5 from Kubilay Kocak <koobs@FreeBSD.org> --- A few review items: /usr/local should never be hardcoded. In this case, since we cant pass it a= s a configuration to the build, use %%PREFIX%% in the patch, and then use REINPLACE_CMD to replace it with the current ${PREFIX} value at post-patch.= [1] Either add a comment above the commented out LICENSE_FILE to explain it ('n= ot yet packaged with distfile'), or leave the line out. Without a comment it l= ooks accidental. Since the python package installs console scripts (things into localbase/bi= n) [2], make the port concurrent versions safe by using USE_PYTHON=3Dconcurren= t, which will automatically version suffix all scripts and create (version-les= s) symlinks to point the versioned scriptnames. This isn't a major issue as the port currently only supports 2.7, but the port should be made concurrent sa= fe anyway. Add comments to patches, in particular for ones that aren't self explanator= y. In this case the patch that adds 'ROUTER_HASH_TYPE =3D None'. You (awesomel= y) explained (most?) of them in your initial comment 0, add those comments and references to the top of all the patches themselves. [1] See: 4.4.3. Simple Automatic Replacements in Porters Handbook [2] https://github.com/graphite-project/carbonate/blob/master/setup.py#L37 --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-227155-13-3e4dN7atVt>