Date: Fri, 4 Jun 2021 14:45:59 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Alexey Dokuchaev <danfe@freebsd.org> Cc: ports-committers@freebsd.org, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org Subject: Re: git: 5d304c338aba - main - games/fheroes2: update to 0.9.4 Message-ID: <YLogh7wQCMaXHVew@KGPE-D16> In-Reply-To: <YLn7Grm5oFyRp9FB@FreeBSD.org> References: <202106040953.1549rbHY052844@gitrepo.freebsd.org> <YLn7Grm5oFyRp9FB@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--JTvxSDaMpVz4w+/B
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On 21-06-04 10:06:18, Alexey Dokuchaev wrote:
> On Fri, Jun 04, 2021 at 09:53:37AM +0000, Piotr Kubaj wrote:
> > commit 5d304c338abaef672b8392ff2d2d0b554106950c
> >=20
> > games/fheroes2: update to 0.9.4
> > =20
> > @@ -8,20 +8,15 @@ COMMENT=3D Free implementation of Heroes of Might and=
Magic II engine
> > LICENSE=3D GPLv2
> > LICENSE_FILE=3D ${WRKSRC}/LICENSE
> > =20
> > -LIB_DEPENDS=3D libtinyxml.so:textproc/tinyxml
> > +LIB_DEPENDS=3D libpng16.so:graphics/png
>=20
> It should be spelled as ``libpng.so:graphics/png'', without 16.
Thanks for info.
>=20
> > -LDFLAGS+=3D -ltinyxml
> > -MAKE_ENV=3D WITHOUT_BUNDLED_LIBS=3D1
>=20
> So, what happened to TinyXML dependency? Is it no longer needed,
> or bundled version is used now for some reason? This wasn't
> mentioned in the commit log.
The bundled one is used, port switched to cmake, which uses pkgconfig for t=
inyxml detection, but tinyxml doesn't provide a pc file for pkgconfig, so t=
hat fails.
>=20
> > +PLIST_FILES=3D bin/${PORTNAME} \
> > + ${DOCSDIR}/README.txt \
> > + ${DOCSDIR}/changelog.txt
Thanks for info.
>=20
> Docfiles should probably be listed as PORTDOCS, not be part of
> the PLIST_FILES.
>=20
> ./danfe
--JTvxSDaMpVz4w+/B
Content-Type: application/pgp-signature; name="signature.asc"
-----BEGIN PGP SIGNATURE-----
iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAmC6IIcACgkQelmbhSCD
nJ3Gzg/9G5S1cLuamCoATSxM5DiffGAz5I6NwNRfYc9dWMnxNwNpMqkvcMpBSF2e
H9C/cNfhGuq91P8QcsPYGxCWUwOO8q2hAgAiULs4lsermYzkW8a8jKLuib9D+ji+
6TWQ8AIvF9VplmMrtug0uPm21NiSdY6vdAWySPt0hKVD+J4jR5DIxDx/xUpJQ+7Y
mvNAO8UUnh2AatrfNOUne5mZqwraoTTPbhc53IP7p3YhHlK1IYL2jDAv5tyhRxE3
pVkeXvLdm15S5xko5Jn4LRl0GVAtFQDJ4VHd2y9Sf/MK/MKXwbhmhgy1jdh/U4iX
/aaRT6vB1DZgG6KQFD4yr616Oi44n6w+8QyoPphEYZ4UPhq2IvMryZOqR0QZKodN
4BPCG3sH3f3vWaZP1hp3Mb2BE0lKwVPk8ooUDG3kTATvuJmhA2CHXVBmL4gYTwel
gmQTTtHNHckYE3h73RBy5u/IZHwT9+xQcIvIILoif0a2keIQqaoopWebO248MLDJ
cqlsKFtm+G4NeKohsjx8VDva46Pufd/Opf7oyU80V0mXCkQ5a9psTbDROgSTGfBZ
vEZ8Tw/H4AmV+InM7BxFvnOdFHhCregxnfsb64fH7gnCDVjTPHPbrGzEFKMLylPL
SpTyAw0nJTQQdjTP3izl07RFv5V/vj6A59es5rnitI/w4Ljwe+4=
=FKp8
-----END PGP SIGNATURE-----
--JTvxSDaMpVz4w+/B--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?YLogh7wQCMaXHVew>