Date: Thu, 14 Oct 2021 02:18:47 +0800 From: Po-Chuan Hsieh <sunpoet@freebsd.org> To: Dima Panov <fluffy@freebsd.org> Cc: Alexey Dokuchaev <danfe@freebsd.org>, Li-Wen Hsu <lwhsu@freebsd.org>, "Sergey A. Osokin" <osa@freebsd.org>, dev-commits-ports-all@freebsd.org, dev-commits-ports-main@freebsd.org, ports-committers@freebsd.org Subject: Re: git: 2bc3e6229feb - main - net-im/telegram-desktop: Update to 3.1.9 Message-ID: <CAMHz58Q57VrqC3kWgH-Z26OvkAYsBzsiZq5nJr2xkiPAx60-ow@mail.gmail.com> In-Reply-To: <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary> References: <202110121357.19CDvdWN002446@gitrepo.freebsd.org> <YWWcR20bUeZJ1I4y@FreeBSD.org> <YWcURc7PrcJA65jY@FreeBSD.org> <09c5ed72-fded-4282-b49f-6d494dff88b8@Canary>
next in thread | previous in thread | raw e-mail | index | archive | help
--00000000000065724705ce4000fc Content-Type: text/plain; charset="UTF-8" On Thu, Oct 14, 2021 at 1:31 AM Dima Panov <fluffy@freebsd.org> wrote: > Moin! > > Have tested the almost same patch. > Small suggestions: > > GTK_USE= GNOME=cairo gtk30 > Do you mean "GTK_USE= GNOME=cairo,gtk30" (use comma instead of space)? GTK_DESC= WebKit-gtk integration > > -- > Dima. (desktop, kde, x11, office, ports-secteam)@FreeBSD team > (fluffy@FreeBSD.org, https://t.me/dima_panov) > > On Wednesday, Oct 13, 2021 at 8:15 PM, Sergey A. Osokin <osa@freebsd.org> > wrote: > Well, I'm not totally sure is my approach is corrent, but here's the > patch returning back GTK staff. Please be aware: it wasn't tested yet. > > -- > Sergey Osokin > > On Tue, Oct 12, 2021 at 02:31:35PM +0000, Alexey Dokuchaev wrote: > > On Tue, Oct 12, 2021 at 01:57:39PM +0000, Li-Wen Hsu wrote: > > commit 2bc3e6229febd07dd7f2980cb7065573d689a0f5 > > net-im/telegram-desktop: Update to 3.1.9 > > > Thanks for updating the port, however... > > ... > @@ -40,6 +39,7 @@ LIB_DEPENDS= libavformat.so:multimedia/ffmpeg \ > libpipewire-0.3.so:multimedia/pipewire \ > libqrcodegencpp.so:graphics/qr-code-generator \ > libusrsctp.so:net/libusrsctp \ > + libwebkit2gtk-4.0.so:www/webkit2-gtk3 \ > > > Commit log does not explain why would light-weight chat program would now > unconditionally depend on this admittedly quite heavy component. > > @@ -52,9 +52,10 @@ USE_GITHUB= nodefault > GH_ACCOUNT= telegramdesktop > GH_PROJECT= tdesktop > USE_GL= gl > -USE_GNOME= glib20 glibmm > +USE_GNOME= glib20 glibmm gtk30 > > > Nor does it explain why Qt-based program now unconditionally requires GTK. > > +INSTALLS_ICONS= yes > > > Please also see the latest CHANGES entry. > > ./danfe > > --00000000000065724705ce4000fc--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAMHz58Q57VrqC3kWgH-Z26OvkAYsBzsiZq5nJr2xkiPAx60-ow>