Date: Wed, 26 Sep 2001 15:35:24 -0700 (PDT) From: John Baldwin <jhb@FreeBSD.org> To: Cy Schubert - ITSD Open Systems Group <Cy.Schubert@uumail.gov.bc.ca> Cc: freebsd-security@FreeBSD.org Subject: RE: OpenSSH Security Advisory (adv.option) (fwd) Message-ID: <XFMail.010926153524.jhb@FreeBSD.org> In-Reply-To: <200109262227.f8QMR6G33342@cwsys.cwsent.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 26-Sep-01 Cy Schubert - ITSD Open Systems Group wrote:
> A weakness in OpenSSH's source IP based access control has been
> discovered.
Looks like your mailer mungled the patch by appending extra '- ' to the
deletion lines. It would be "fixed" below except that my mailer has the
braindead "feature" of converting tabs to spaces w/o any way to disable it that
I can find.
Index: key.c
===================================================================
RCS file: /cvs/src/usr.bin/ssh/key.c,v
retrieving revision 1.31
retrieving revision 1.32
diff -u -p -IRCSID -r1.31 -r1.32
--- key.c 2001/09/17 20:50:22 1.31
+++ key.c 2001/09/19 13:23:29 1.32
@@ -358,7 +358,7 @@ write_bignum(FILE *f, BIGNUM *num)
return 1;
}
-/* returns 1 ok, -1 error, 0 type mismatch */
+/* returns 1 ok, -1 error */
int
key_read(Key *ret, char **cpp)
{
@@ -413,7 +413,7 @@ key_read(Key *ret, char **cpp)
} else if (ret->type != type) {
/* is a key, but different type */
debug3("key_read: type mismatch");
- return 0;
+ return -1;
}
len = 2*strlen(cp);
blob = xmalloc(len);
--
John Baldwin <jhb@FreeBSD.org> -- http://www.FreeBSD.org/~jhb/
PGP Key: http://www.baldwin.cx/~john/pgpkey.asc
"Power Users Use the Power to Serve!" - http://www.FreeBSD.org/
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-security" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.010926153524.jhb>