Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Aug 2024 14:29:59 GMT
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org
Subject:   git: c8d02c3763b9 - stable/14 - ithread: Annotate a branch in ithread_execute_handlers()
Message-ID:  <202408151429.47FETxKR016678@gitrepo.freebsd.org>

next in thread | raw e-mail | index | archive | help
The branch stable/14 has been updated by markj:

URL: https://cgit.FreeBSD.org/src/commit/?id=c8d02c3763b9c19c5829741336ff84f97819a143

commit c8d02c3763b9c19c5829741336ff84f97819a143
Author:     Mark Johnston <markj@FreeBSD.org>
AuthorDate: 2024-07-30 14:36:35 +0000
Commit:     Mark Johnston <markj@FreeBSD.org>
CommitDate: 2024-08-15 14:29:49 +0000

    ithread: Annotate a branch in ithread_execute_handlers()
    
    No functional change intended.
    
    Reviewed by:    kib, jhb
    MFC after:      2 weeks
    Differential Revision:  https://reviews.freebsd.org/D45491
    
    (cherry picked from commit c122d7ffad5efb31e1aa5035cb1a26ad2e479074)
---
 sys/kern/kern_intr.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c
index 6869d9112ea9..2e8ed6c5ece9 100644
--- a/sys/kern/kern_intr.c
+++ b/sys/kern/kern_intr.c
@@ -1203,8 +1203,9 @@ ithread_execute_handlers(struct proc *p, struct intr_event *ie)
 	 * number of back to back interrupts exceeds the storm threshold,
 	 * then enter storming mode.
 	 */
-	if (intr_storm_threshold != 0 && ie->ie_count >= intr_storm_threshold &&
-	    !(ie->ie_flags & IE_SOFT)) {
+	if (__predict_false(intr_storm_threshold != 0 &&
+	    ie->ie_count >= intr_storm_threshold &&
+	    (ie->ie_flags & IE_SOFT) == 0)) {
 		/* Report the message only once every second. */
 		if (ppsratecheck(&ie->ie_warntm, &ie->ie_warncnt, 1)) {
 			printf(



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202408151429.47FETxKR016678>