Date: Tue, 6 Oct 2009 09:20:03 GMT From: Gaurav Goel <gaurav0287@gmail.com> To: freebsd-net@FreeBSD.org Subject: Re: kern/138652: TCP window scaling value calculated incorrectly? Message-ID: <200910060920.n969K3K9071480@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/138652; it has been noted by GNATS.
From: Gaurav Goel <gaurav0287@gmail.com>
To: bug-followup@freebsd.org
Cc:
Subject: Re: kern/138652: TCP window scaling value calculated incorrectly?
Date: Tue, 6 Oct 2009 14:47:52 +0530
--000feaf371bd7882aa047540b470
Content-Type: text/plain; charset=UTF-8
Hi,
May I know if someone is working on the bug. I have provided the solution
too, but didn't get any response.
Thanks,
Gaurav Goel
On Thu, Sep 10, 2009 at 7:00 PM, Gaurav Goel <gaurav0287@gmail.com> wrote:
> Dear Gavin,
>
> Please find the fix for the problem:
>
> *Replace*
> * while (tp->request_r_scale < TCP_MAX_WINSHIFT &&
> (TCP_MAXWIN << tp->request_r_scale) < sb_max)
> tp->request_r_scale++;*
>
> *With*
> *unsigned int new_TCP_MAXWIN = TCP_MAXWIN;
> while (tp->request_r_scale < TCP_MAX_WINSHIFT)
> {
> if(new_TCP_MAXWIN < sb_max)
> tp->request_r_scale++;
> else
> break;**
> ** new_TCP_MAXWIN <<=1;**
> ** new_TCP_MAXWIN |=1;**
> **}*
>
> Please inform me if I am right/wrong.
>
> Thanks,
> Gaurav Goel
>
>
> On Wed, Sep 9, 2009 at 7:59 PM, <gavin@freebsd.org> wrote:
>
>> Old Synopsis: TCP window scaling value
>> New Synopsis: TCP window scaling value calculated incorrectly?
>>
>> State-Changed-From-To: feedback->open
>> State-Changed-By: gavin
>> State-Changed-When: Wed Sep 9 14:24:24 UTC 2009
>> State-Changed-Why:
>> Over to maintainer(s) for investigation
>>
>>
>> Responsible-Changed-From-To: gavin->freebsd-net
>> Responsible-Changed-By: gavin
>> Responsible-Changed-When: Wed Sep 9 14:24:24 UTC 2009
>> Responsible-Changed-Why:
>> Feedback was received, thanks!
>>
>> http://www.freebsd.org/cgi/query-pr.cgi?pr=138652
>>
>
>
>
> --
> Gaurav Goel
>
--
Gaurav Goel
--000feaf371bd7882aa047540b470
Content-Type: text/html; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Hi,<br><br>May I know if someone is working on the bug. I have provided the=
solution too, but didn't get any response.<br><br>Thanks,<br>Gaurav Go=
el<br><br><div class=3D"gmail_quote">On Thu, Sep 10, 2009 at 7:00 PM, Gaura=
v Goel <span dir=3D"ltr"><<a href=3D"mailto:gaurav0287@gmail.com">gaurav=
0287@gmail.com</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Dear Gavin,<br><b=
r>Please find the fix for the problem:<br><br><u><b>Replace</b></u><br><b><=
span style=3D"color: rgb(153, 0, 0); background-color: rgb(255, 255, 255);"=
>=C2=A0=C2=A0=C2=A0 while (tp->request_r_scale < TCP_MAX_WINSHIFT &am=
p;&</span><br style=3D"color: rgb(153, 0, 0); background-color: rgb(255=
, 255, 255);">
<span style=3D"color: rgb(153, 0, 0); background-color: rgb(255, 255, 255);=
">=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 (TCP_MAXWIN << tp->request=
_r_scale) < sb_max)</span><br style=3D"color: rgb(153, 0, 0); background=
-color: rgb(255, 255, 255);">
<span style=3D"color: rgb(153, 0, 0); background-color: rgb(255, 255, 255);=
">=C2=A0=C2=A0=C2=A0 =C2=A0=C2=A0=C2=A0 tp->request_r_scale++;</span></b=
><br>
<br><u><b>With</b></u><br><b><span style=3D"color: rgb(0, 153, 0);">unsigne=
d int new_TCP_MAXWIN =3D TCP_MAXWIN;</span><br style=3D"color: rgb(0, 153, =
0);"><span style=3D"color: rgb(0, 153, 0);">while (tp->request_r_scale &=
lt; TCP_MAX_WINSHIFT)</span><br style=3D"color: rgb(0, 153, 0);">
<span style=3D"color: rgb(0, 153, 0);">{</span><span style=3D"color: rgb(0,=
153, 0);"></span><br style=3D"color: rgb(0, 153, 0);"><span style=3D"color=
: rgb(0, 153, 0);">=C2=A0=C2=A0=C2=A0 if(new_TCP_MAXWIN < sb_max)</span>=
<br style=3D"color: rgb(0, 153, 0);">
<span style=3D"color: rgb(0, 153, 0);">=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0 tp->request_r_scale++;</span><br style=3D"color: rgb(0, 153, 0);"=
><span style=3D"color: rgb(0, 153, 0);">=C2=A0=C2=A0=C2=A0 else</span><br s=
tyle=3D"color: rgb(0, 153, 0);"><span style=3D"color: rgb(0, 153, 0);">=C2=
=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 break;</span></b><b><span style=3D"=
color: rgb(0, 153, 0);"></span><br style=3D"color: rgb(0, 153, 0);">
<span style=3D"color: rgb(0, 153, 0);"></span></b><b><span style=3D"color: =
rgb(0, 153, 0);">=C2=A0=C2=A0=C2=A0 new_TCP_MAXWIN <<=3D1;</span></b>=
<b><br style=3D"color: rgb(0, 153, 0);"></b><b><span style=3D"color: rgb(0,=
153, 0);">=C2=A0=C2=A0=C2=A0 new_TCP_MAXWIN |=3D1;</span></b><b><br style=
=3D"color: rgb(0, 153, 0);">
</b><b><span style=3D"color: rgb(0, 153, 0);">}</span></b><br><br>Please in=
form me if I am right/wrong.<br><br>Thanks,<br>Gaurav Goel<div><div></div><=
div class=3D"h5"><br><br><div class=3D"gmail_quote">On Wed, Sep 9, 2009 at =
7:59 PM, <span dir=3D"ltr"><<a href=3D"mailto:gavin@freebsd.org" target=
=3D"_blank">gavin@freebsd.org</a>></span> wrote:<br>
<blockquote class=3D"gmail_quote" style=3D"border-left: 1px solid rgb(204, =
204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">Old Synopsis: TCP=
window scaling value<br>
New Synopsis: TCP window scaling value calculated incorrectly?<br>
<br>
State-Changed-From-To: feedback->open<br>
State-Changed-By: gavin<br>
State-Changed-When: Wed Sep 9 14:24:24 UTC 2009<br>
State-Changed-Why:<br>
Over to maintainer(s) for investigation<br>
<br>
<br>
Responsible-Changed-From-To: gavin->freebsd-net<br>
Responsible-Changed-By: gavin<br>
Responsible-Changed-When: Wed Sep 9 14:24:24 UTC 2009<br>
Responsible-Changed-Why:<br>
Feedback was received, thanks!<br>
<br>
<a href=3D"http://www.freebsd.org/cgi/query-pr.cgi?pr=3D138652" target=3D"_=
blank">http://www.freebsd.org/cgi/query-pr.cgi?pr=3D138652</a><br>;
</blockquote></div><br><br clear=3D"all"><br></div></div>-- <br><font color=
=3D"#888888">Gaurav Goel<br>
</font></blockquote></div><br><br clear=3D"all"><br>-- <br>Gaurav Goel<br>
--000feaf371bd7882aa047540b470--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200910060920.n969K3K9071480>