Date: Fri, 30 Nov 2018 09:30:42 -0800 From: John Baldwin <jhb@FreeBSD.org> To: Andrew Rybchenko <arybchik@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r341327 - head/sys/dev/sfxge Message-ID: <d60f54ae-a1a6-bad5-73f0-c898d0579089@FreeBSD.org> In-Reply-To: <201811300711.wAU7B5R6084752@repo.freebsd.org> References: <201811300711.wAU7B5R6084752@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 11/29/18 11:11 PM, Andrew Rybchenko wrote: > Author: arybchik > Date: Fri Nov 30 07:11:05 2018 > New Revision: 341327 > URL: https://svnweb.freebsd.org/changeset/base/341327 > > Log: > sfxge(4): rollback last seen VLAN TCI if Tx packet is dropped > > Early processing of a packet on transmit may change last seen > VLAN TCI in the queue context. If such a packet is eventually > dropped, last seen VLAN TCI must be set to its previous value. > > Submitted by: Ivan Malov <Ivan.Malov at oktetlabs.ru> > Sponsored by: Solarflare Communications, Inc. > MFC after: 1 week > Differential Revision: https://reviews.freebsd.org/D18288 Just as a general comment. There's no point in creating a review in phabricator if you aren't going to get any actual review feedback via the tool. That just adds noise. (I've spotchecked a few of the recent sfxge commits and they all seem to create a review that then gets committed a few hours later without any feedback, etc.) -- John Baldwin
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?d60f54ae-a1a6-bad5-73f0-c898d0579089>