Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 30 May 2004 02:04:37 +0200
From:      Oliver Eikemeier <eikemeier@fillmore-labs.com>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/67361: [PATCH] bsd.port.mk: proposal to source out distfile handling to a shell script
Message-ID:  <40B92515.1090000@fillmore-labs.com>
Resent-Message-ID: <200405300010.i4U0AfgW041822@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         67361
>Category:       ports
>Synopsis:       [PATCH] bsd.port.mk: proposal to source out distfile handling to a shell script
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Sat May 29 17:10:41 PDT 2004
>Closed-Date:
>Last-Modified:
>Originator:     Oliver Eikemeier
>Release:        FreeBSD 4.10-STABLE i386
>Organization:
Fillmore Labs - http://www.fillmore-labs.com
>Environment:
System: FreeBSD nuuk.fillmore-labs.com 4.10-STABLE

>Description:

The distfile handling code in bsd.port.mk is becoming excessively complex.

This is a proposal to replace the do-fetch/checksum/makesum/fetch-list
targets with a shell script, eliminating more than 1/2k lines of
code. The primary focus is to break down bsd.port.mk into components,
in order to make refactoring posssible.

As a side effect, time critical operations, such as INDEX builds and
port surveys should run a little faster, while distfiles handling
operations like fetching and extracting are mostly not affected by
make(1) running times.


>How-To-Repeat:
>Fix:

A prototype patch and shell script is at
  <http://people.freebsd.org/~eik/patches/distfiles/>;

This patch integrates and obsoletes:
- PR 56641: support for SHA1 and other algorithms in distinfo
- PR 62271: calculate size of needed distribution files
- PR 63933: support for sorting MASTER_SITES by table lookup
- PR 64157: new target check-distfiles

While I use this script on my machines without further problems, it
could benefit from review and widespread testing on different
configurations.


-Oliver
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?40B92515.1090000>