Date: Mon, 27 Oct 2014 16:04:37 +0100 From: Julio Merino <jmmv@freebsd.org> To: Garrett Cooper <yaneurabeya@gmail.com> Cc: "freebsd-testing@freebsd.org" <freebsd-testing@freebsd.org>, Alfred Perlstein <alfred@freebsd.org> Subject: Re: Panicking UUTs and integrating the ZFS test suite into the default run Message-ID: <CAFY7cWANUQekdG4fhRESap=JR49Mojh9NmOFoBq2a6EQEe15Sw@mail.gmail.com> In-Reply-To: <86E89F83-179D-4301-9EC0-0ECC3909B924@gmail.com> References: <CAG=rPVe-hCYiH5YuC%2BrzrucJbHJvEFmik0RAA%2Brq%2BXQ5K_A0Ww@mail.gmail.com> <20141024053636.GH11222@dft-labs.eu> <CAHM0Q_MOLoYGVhVOwAHfxKmMdX8bBK0Y=OoiR0TR=t3kQyYtVQ@mail.gmail.com> <CAG=rPVcRkCtwjNdzO2p6PuMVTLTFh7qKN=pxPVDrE0DM=R_a9w@mail.gmail.com> <81030948-E60F-4AAD-AAF1-16349607917D@gmail.com> <544B46BA.4000008@freebsd.org> <CAG=rPVexyG_ZW8%2BXPWUu6Dt7--ZjwKG7Wtga3esR0JqpJPJtPw@mail.gmail.com> <86E89F83-179D-4301-9EC0-0ECC3909B924@gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, Oct 25, 2014 at 8:59 PM, Garrett Cooper <yaneurabeya@gmail.com> wrote:
> (moving to -testing and renaming because this is turning into a bikeshed discussion)
>
> On Oct 25, 2014, at 9:49, Craig Rodrigues <rodrigc@freebsd.org> wrote:
>
>> On Fri, Oct 24, 2014 at 11:44 PM, Alfred Perlstein <alfred@freebsd.org> wrote:
>
> 6
> 7 [ "${os}" = "FreeBSD" ] && die "panics FreeBSD; see bug # 194589"
> 8
>
> 1. The issue is documented, so developers and testers know where to get the bug information
> 2. The test is marked as a failure.
>
> Both of these items encourage testers and other developers to go prod developers with knowledge and cycles to go fix the bugs so things eventually turn green.
That's bad as well. Marking tests as broken trains developers to
ignore failures and to be more lax in tolerating breakage, and thus
makes the signal from the test suite useless. Developers must be able
to trust the results of the test suite, and to understand that a flip
from green to red is really bad. Thinking "Hey, the build has been red
like, forever, so one more broken test from me is irrelevant!" is
quite common.
These tests must be kept green if they are for known problems. A way
to do so is with "expected failures", which I think you can denote in
TAP with the "TODO" keyword and with expect_fail in ATF.
Regarding the panics: making the box panic every time the test runs is
probably not a great idea... but this is a shortcoming caused by our
inability to properly test the kernel in an isolated environment. (In
NetBSD, we'd use rump for this and thus the machine would never
panic.)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAFY7cWANUQekdG4fhRESap=JR49Mojh9NmOFoBq2a6EQEe15Sw>