Date: Sun, 2 Feb 2025 16:37:55 GMT From: Warner Losh <imp@FreeBSD.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: git: ead758a67a6b - main - pms: Fix always true condition Message-ID: <202502021637.512Gbt1K075576@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by imp: URL: https://cgit.FreeBSD.org/src/commit/?id=ead758a67a6b584293cfe02cd6c5cbefb6a4926f commit ead758a67a6b584293cfe02cd6c5cbefb6a4926f Author: Svyatoslav <razmyslov@viva64.com> AuthorDate: 2025-02-02 16:35:51 +0000 Commit: Warner Losh <imp@FreeBSD.org> CommitDate: 2025-02-02 16:35:51 +0000 pms: Fix always true condition Although this is vendor code, and apparently abandoned vendor code at that, this is clearly a mistake and always true. It's unclear how to contribute back to the upstream at this point, alas. PR: 217745 Reviewed by: imp --- sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c b/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c index 541940c5fda8..6a45e954d315 100644 --- a/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c +++ b/sys/dev/pms/RefTisa/sallsdk/spc/sampirsp.c @@ -7217,7 +7217,7 @@ GLOBAL bit32 mpiDekManagementRsp( agEvent.encryptOperation = OSSA_HW_ENCRYPT_DEK_INVALIDTE; } agEvent.status = status; - if (status == OSSA_MPI_ENC_ERR_ILLEGAL_DEK_PARAM || OSSA_MPI_ERR_DEK_MANAGEMENT_DEK_UNWRAP_FAIL) + if (status == OSSA_MPI_ENC_ERR_ILLEGAL_DEK_PARAM || status == OSSA_MPI_ERR_DEK_MANAGEMENT_DEK_UNWRAP_FAIL) { agEvent.eq = errorQualifier; }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202502021637.512Gbt1K075576>