Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 30 Jan 2023 00:03:54 +0100
From:      Dimitry Andric <dim@FreeBSD.org>
To:        =?utf-8?Q?Stefan_E=C3=9Fer?= <se@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org>
Subject:   Re: git: fdd4c35832de - main - usr.bin/gh-bc: update Makefiles for version 6.2.2
Message-ID:  <39329938-5118-440B-B567-77AB64732BD1@FreeBSD.org>
In-Reply-To: <202301282250.30SMon4s075057@gitrepo.freebsd.org>
References:  <202301282250.30SMon4s075057@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help

--Apple-Mail=_35FFDC62-5D88-4464-A748-C8BC084FA298
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=utf-8

On 28 Jan 2023, at 23:50, Stefan E=C3=9Fer <se@FreeBSD.org> wrote:
>=20
> The branch main has been updated by se:
>=20
> URL: =
https://cgit.FreeBSD.org/src/commit/?id=3Dfdd4c35832deb1d064f64c2c00e3c8c9=
58be9a51
>=20
> commit fdd4c35832deb1d064f64c2c00e3c8c958be9a51
> Author:     Stefan E=C3=9Fer <se@FreeBSD.org>
> AuthorDate: 2023-01-28 22:48:34 +0000
> Commit:     Stefan E=C3=9Fer <se@FreeBSD.org>
> CommitDate: 2023-01-28 22:48:34 +0000
>=20
>    usr.bin/gh-bc: update Makefiles for version 6.2.2
...
> -CFLAGS+=3D -DMAINEXEC=3D${PROGNAME}
> -CFLAGS+=3D -DNLSPATH=3D/usr/share/nls/%L/%N.cat
> -CFLAGS+=3D -DBUILD_TYPE=3DA
> +CFLAGS=3D-g -O0

This assignment instead of using "+=3D" appears to have broken the
riscv64sf build for me, since it passes "-march=3Drv64imac -mabi=3Dlp64" =
via
the global CFLAGS to target the soft-float ABI.

That said, is -g -O0 maybe a debugging aid that you left in by accident?
Is there any reason not to compile bc with the regular, user-specified
CFLAGS? In that case, the line might just be deleted.

-Dimitry


--Apple-Mail=_35FFDC62-5D88-4464-A748-C8BC084FA298
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Version: GnuPG/MacGPG2 v2.2

iF0EARECAB0WIQR6tGLSzjX8bUI5T82wXqMKLiCWowUCY9b7WgAKCRCwXqMKLiCW
o28qAJ9Y4hmwgTLfisTjHhq6oyGRw5DRTwCgsa4pgdwPmILTMOa3/BZqErFw2aM=
=hGSz
-----END PGP SIGNATURE-----

--Apple-Mail=_35FFDC62-5D88-4464-A748-C8BC084FA298--



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?39329938-5118-440B-B567-77AB64732BD1>