Date: Sat, 27 Sep 1997 02:03:43 -0400 (EDT) From: Jack <jack@zeus.xtalwind.net> To: FreeBSD-gnats-submit@FreeBSD.ORG Subject: misc/4636: sysinstall upgrade overwrites /etc network files before backing them up Message-ID: <199709270603.CAA06931@zeus.xtalwind.net> Resent-Message-ID: <199709270610.XAA00666@hub.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 4636
>Category: misc
>Synopsis: sysinstall upgrade overwrites /etc network files before backing them up
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-bugs
>State: open
>Class: sw-bug
>Submitter-Id: current-users
>Arrival-Date: Fri Sep 26 23:10:01 PDT 1997
>Last-Modified:
>Originator: Jack
>Organization:
>Release: FreeBSD 2.2-STABLE i386
>Environment:
>Description:
Upgrade install overwrites /etc/hosts, /etc/resolv.conf, and /etc/ppp/ppp.conf, /etc/ppp/ppp.linkup during ppp install, before backing up /etc
>How-To-Repeat:
Choose upgrade from the sysinstall menu
>Fix:
Backup all /etc files before writing.
*** installUpgrade.c.orig Sat Sep 27 01:32:30 1997
--- installUpgrade.c Sat Sep 27 01:33:57 1997
***************
*** 252,271 ****
systemCreateHoloshell();
}
- media:
- if (!mediaVerify())
- return DITEM_FAILURE | DITEM_RESTORE;
-
- if (!mediaDevice->init(mediaDevice)) {
- if (!msgYesNo("Couldn't initialize the media. Would you like\n"
- "to adjust your media selection and try again?")) {
- mediaDevice = NULL;
- goto media;
- }
- else
- return DITEM_FAILURE | DITEM_REDRAW;
- }
-
saved_etc = NULL;
if (extractingBin) {
while (!saved_etc) {
--- 252,257 ----
***************
*** 300,305 ****
--- 286,305 ----
}
}
+ media:
+ if (!mediaVerify())
+ return DITEM_FAILURE | DITEM_RESTORE;
+
+ if (!mediaDevice->init(mediaDevice)) {
+ if (!msgYesNo("Couldn't initialize the media. Would you like\n"
+ "to adjust your media selection and try again?")) {
+ mediaDevice = NULL;
+ goto media;
+ }
+ else
+ return DITEM_FAILURE | DITEM_REDRAW;
+ }
+
msgNotify("Beginning extraction of distributions..");
if (DITEM_STATUS(distExtractAll(self)) == DITEM_FAILURE) {
msgConfirm("Hmmmm. We couldn't even extract the bin distribution. This upgrade\n"
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199709270603.CAA06931>