Date: Mon, 17 Jul 2023 11:54:09 -0600 From: Warner Losh <imp@bsdimp.com> To: John Baldwin <jhb@freebsd.org> Cc: Warner Losh <imp@freebsd.org>, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: d3152ab23e0e - main - tcbpcb: Always define t_osd Message-ID: <CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA@mail.gmail.com> In-Reply-To: <ba89809b-0af3-8eb6-afd2-68606450f186@FreeBSD.org> References: <202307171735.36HHZonv063454@gitrepo.freebsd.org> <ba89809b-0af3-8eb6-afd2-68606450f186@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] On Mon, Jul 17, 2023 at 11:52 AM John Baldwin <jhb@freebsd.org> wrote: > On 7/17/23 10:35 AM, Warner Losh wrote: > > The branch main has been updated by imp: > > > > URL: > https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > > > > commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057 > > Author: Warner Losh <imp@FreeBSD.org> > > AuthorDate: 2023-07-17 17:22:45 +0000 > > Commit: Warner Losh <imp@FreeBSD.org> > > CommitDate: 2023-07-17 17:22:45 +0000 > > > > tcbpcb: Always define t_osd > > > > Always define t_osd. congestion control modules access it > > unconditionally. This fixes the build. > > > > However, this is, at best, a temporary band-aide until the > > larger issues are sorted. > > > > Sponsored by: Netflix > > FWIW, I find that #ifdef's based on kernel options in "core" structures > like this > shared with modules is a recipe for disaster. > Agreed 100% Just trying to get to closure on that concept with all the concerned parties.... Warner [-- Attachment #2 --] <div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Mon, Jul 17, 2023 at 11:52 AM John Baldwin <<a href="mailto:jhb@freebsd.org">jhb@freebsd.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">On 7/17/23 10:35 AM, Warner Losh wrote:<br> > The branch main has been updated by imp:<br> > <br> > URL: <a href="https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057" rel="noreferrer" target="_blank">https://cgit.FreeBSD.org/src/commit/?id=d3152ab23e0e7bee5a0f988ecca2a1187ab82057</a><br>; > <br> > commit d3152ab23e0e7bee5a0f988ecca2a1187ab82057<br> > Author: Warner Losh <imp@FreeBSD.org><br> > AuthorDate: 2023-07-17 17:22:45 +0000<br> > Commit: Warner Losh <imp@FreeBSD.org><br> > CommitDate: 2023-07-17 17:22:45 +0000<br> > <br> > tcbpcb: Always define t_osd<br> > <br> > Always define t_osd. congestion control modules access it<br> > unconditionally. This fixes the build.<br> > <br> > However, this is, at best, a temporary band-aide until the<br> > larger issues are sorted.<br> > <br> > Sponsored by: Netflix<br> <br> FWIW, I find that #ifdef's based on kernel options in "core" structures like this<br> shared with modules is a recipe for disaster.<br></blockquote><div><br></div><div>Agreed 100% Just trying to get to closure on that concept with all the concerned</div><div>parties....</div><div><br></div><div>Warner </div></div></div>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfp-1zbXXMenHS3rRzC8-8bR-dgOttMPYdGVBBi0Lt25zA>