Date: Tue, 7 Apr 2020 19:22:26 +1000 From: Peter Jeremy <peter@rulingia.com> To: Wojciech Macek <wma@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r359647 - in head/sys: arm64/broadcom arm64/broadcom/brcmmdio conf dev/mdio Message-ID: <20200407092226.GA89740@server.rulingia.com> In-Reply-To: <202004060548.0365mwYZ065227@repo.freebsd.org> References: <202004060548.0365mwYZ065227@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--IJpNTDwzlM2Ie8A6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 2020-Apr-06 05:48:58 +0000, Wojciech Macek <wma@FreeBSD.org> wrote: >Log: > Add MDIO PHY driver for NS2 ARM64 platform. =2E.. >Modified: head/sys/conf/files.arm64 >=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >--- head/sys/conf/files.arm64 Mon Apr 6 04:06:15 2020 (r359646) >+++ head/sys/conf/files.arm64 Mon Apr 6 05:48:58 2020 (r359647) >@@ -176,6 +176,9 @@ arm64/arm64/undefined.c standard > arm64/arm64/unwind.c optional ddb | kdtrace_hooks | stack > arm64/arm64/vfp.c standard > arm64/arm64/vm_machdep.c standard >+arm64/broadcom/brcmmdio/mdio_mux_iproc.c optional fdt >+arm64/broadcom/brcmmdio/mdio_nexus_iproc.c optional fdt >+arm64/broadcom/brcmmdio/mdio_ns2_pcie_phy.c optional fdt pci I don't believe this is correct. These files are only relevant to a subset of Broadcom SoCs and (IMO) should not be included merely with "options FDT", rather they should be conditional on the relevant Broadcom SoCs. --=20 Peter Jeremy --IJpNTDwzlM2Ie8A6 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEE2M6l8vfIeOACl4uUHZIUommfjLIFAl6MRkhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEQ4 Q0VBNUYyRjdDODc4RTAwMjk3OEI5NDFEOTIxNEEyNjk5RjhDQjIACgkQHZIUommf jLLyeg/+LSwJ+x2JUWhd1jE69GsnjKC2ZvzR794deEGgOBlOHHDM2LNrTnS3qTuq NP+sKQfJ5J36QrdmRY7oVLLvvJliBKOr6vYUvaEpV9HWxN/TuF1DwDgDD3NsacHh 9og/wZj3gU/k51AGhY3bPqiRw997vYkQlAp8VPxAk5VwkQhwbDVtwEqK8TqbEzt2 Kf4MTDmbzIhyPrUxnVsAPhGuEuISgSaHAeLfeFnN4NE6/BT6dXc80jI76f6mlvvO +HzqTJo/GEr+jciTJ+t5MiFKuVdkH+Cge1T2+r3K5K4/cTdSRYQ4RXNMEeSKnxAf FEDswInSh1XUjaUhrvzycMbs38RvDNipcmy2smQlmo495Zn3texea0Fnpb4dQemp QU3I9/Px5qdzvHuBrnwQLq+M0QW4ZnbSxZzwXE0S0DqDkCsW2kHnIf2hesKEwALS f7J/qLEJ8p7cSL5xzEFnrQfZYaPmoNz5xNzHmegTNP/4Jim6+f1mrb4rpXMIfJkw uTemKWgBuB7oxvcs5YGCXLJ1dtzpLd9oxvNeJT2Jyl4FyEpaYoaSqVuXHE3pQrJJ DuJZd2t0VI6gyUuba+kmGfMTp6KnOekVmrt8C5fc6F6K3fADbGez/yuhkXz2qkm4 77YMiPlhmYtdkg2CwWQu1hssR3AG0grrcuStgXVaK9ApsZKqNGw= =EJqe -----END PGP SIGNATURE----- --IJpNTDwzlM2Ie8A6--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200407092226.GA89740>