Date: Wed, 5 Dec 2012 10:31:34 +0400 From: Vladimir Timofeev <vovkasm@gmail.com> To: Steve Wills <swills@freebsd.org> Cc: perl@freebsd.org Subject: Re: p5- port testing Message-ID: <CA%2BPuGkNhTMfr1MONWp8EyeJGzAkxyU-bwSKQkPAPPs0y2p3D=A@mail.gmail.com> In-Reply-To: <38866d12f1539d327825fc1f8451d515.squirrel@mouf.net> References: <38866d12f1539d327825fc1f8451d515.squirrel@mouf.net>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --] Year of silence... Perl is a language with very mature test culture. Why we can't utilize it? Why we can't add regression-test target? Can I help with this? Mk/bsd.cran.mk has unified "regression-test" target, Others have it in individual ports, counts: all: 292 ports p5: 52 ports Why individual maintainers should invent his own "regression-test" target? So I propose to add "regression-test" target to Mk/bsd.perl.mk This would allow: 1. To maintainers easy test their ports 2. Build packages with more quality 3. Later we can automatically send the test failures to CPANTS, so the real developers of CPAN-modules can have direct feedback on errors in their modules with freebsd I already use modified Mk/bsd.perl.mk for some time on my system (attached patch). On Thu, Nov 17, 2011 at 10:01 PM, Steve Wills <swills@freebsd.org> wrote: > Hi, > > Recently versions of ports-mgmt/tinderbox have support for TEST_DEPENDS. > That, plus the attached patch, plus adding "export USE_PERL_TEST=yes" to > .../tinderbox/scripts/etc/env/GLOBAL gives us the ability to automatically > run test on p5- ports in tinderbox. Would anyone be interested in > committing the patch to bsd.perl.mk? > > Also attached is a list of p5- ports that fail their "make test" with this > enabled. I have been slowly working through this list, if anyone else is > interested in helping out, that would be great. Usually it's just missing > BUILD_DEPENDS or TEST_DEPENDS, but often there are more significant > problems. The list is incomplete, this is just what I've happened to find. > > Steve > > _______________________________________________ > freebsd-perl@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-perl > To unsubscribe, send any mail to "freebsd-perl-unsubscribe@freebsd.org" > -- Vladimir Timofeev <vovkasm@gmail.com> [-- Attachment #2 --] Index: Mk/bsd.perl.mk =================================================================== --- Mk/bsd.perl.mk (revision 308262) +++ Mk/bsd.perl.mk (working copy) @@ -213,6 +213,12 @@ ${PERL5} -pi -e 's/ doc_(perl|site|\$$\(INSTALLDIRS\))_install$$//' Makefile .endif # !defined(PERL_MODBUILD) .endif # !target(do-configure) + +.if !target(do-regression-test) +do-regression-test: + @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${MAKE} ${MAKE_FLAGS} ${MAKEFILE} ${_MAKE_JOBS} ${MAKE_ARGS} test) +.endif # !target(do-regression-test) + .endif # defined(PERL_CONFIGURE) .if defined(PERL_MODBUILD) @@ -221,6 +227,11 @@ @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${PERL5} ${PL_BUILD} ${MAKE_ARGS} ${ALL_TARGET}) .endif # !target(do-build) +.if !target(do-regression-test) +do-regression-test: + @(cd ${BUILD_WRKSRC}; ${SETENV} ${MAKE_ENV} ${PERL5} ${PL_BUILD} ${MAKE_ARGS} test) +.endif # !target(do-regression-test) + .if !defined(USE_GMAKE) .if !target(do-install) do-install: @@ -228,4 +239,11 @@ .endif # !target(do-install) .endif # !defined(USE_GMAKE) .endif # defined(PERL_MODBUILD) + +.if !target(regression-test) + +regression-test: build do-regression-test + +.endif # !target(regression-test) + .endif # defined(_POSTMKINCLUDED) && !defined(Perl_Post_Include)
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CA%2BPuGkNhTMfr1MONWp8EyeJGzAkxyU-bwSKQkPAPPs0y2p3D=A>