Date: Wed, 20 Jun 2012 12:23:52 -0500 From: Brooks Davis <brooks@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: Bjoern Zeeb <bz@freebsd.org>, current@freebsd.org Subject: Re: [PATCH] Trim some noise from the daily disk check Message-ID: <20120620172352.GA97444@lor.one-eyed-alien.net> In-Reply-To: <201206200935.27511.jhb@freebsd.org>
index | next in thread | previous in thread | raw e-mail
[-- Attachment #1 --] On Wed, Jun 20, 2012 at 09:35:27AM -0400, John Baldwin wrote: > The daily periodic e-mails for my boxes always include useless output from > dump -W. I think the daily e-mail should only do that if the sysadmin is > actually using dump. The patch below skips the dump reporting it > /etc/dumpdates doesn't exist or exists and is an empty file (the latter is > what you get out-of-the-box): > > Index: 400.status-disks > =================================================================== > --- 400.status-disks (revision 237227) > +++ 400.status-disks (working copy) > @@ -19,13 +19,16 @@ case "$daily_status_disks_enable" in > df $daily_status_disks_df_flags && rc=1 || rc=3 > > # display which filesystems need backing up > - if ! [ -f /etc/fstab ]; then > - export PATH_FSTAB=/dev/null > + if [ -s /etc/dumpdates ]; then > + if ! [ -f /etc/fstab ]; then > + export PATH_FSTAB=/dev/null > + fi > + > + echo "" > + dump W || rc=3 > fi > + ;; > > - echo "" > - dump W || rc=3;; > - > *) rc=0;; > esac > > Thoughts? This seems sensible to me. -- Brooks [-- Attachment #2 --] -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (FreeBSD) iD8DBQFP4gcnXY6L6fI4GtQRAgIhAJ4iUoW4pVm+ejmoikKjdZAiOzFjmQCggO/H /9C426YZI7nW4EkEHQXtqeM= =2sVV -----END PGP SIGNATURE-----home | help
Want to link to this message? Use this
URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20120620172352.GA97444>