Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 2 Feb 2024 14:50:47 -0800
From:      John Baldwin <jhb@FreeBSD.org>
To:        Warner Losh <imp@bsdimp.com>, Warner Losh <imp@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: 5fdf01dbeef1 - main - Revert "stand/lua: always allow overriding with local config files"
Message-ID:  <5faea9f0-80f2-4d07-84e5-876ee54c1870@FreeBSD.org>
In-Reply-To: <CANCZdfoBKQWC-5fmpFrwx%2BxW%2Br7vvO%2B0AAaYFcZQQAmGiHq0mg@mail.gmail.com>
References:  <202402021906.412J667P054855@gitrepo.freebsd.org> <CANCZdfoBKQWC-5fmpFrwx%2BxW%2Br7vvO%2B0AAaYFcZQQAmGiHq0mg@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 2/2/24 11:11 AM, Warner Losh wrote:
> On Fri, Feb 2, 2024 at 12:06 PM Warner Losh <imp@freebsd.org> wrote:
> 
>> The branch main has been updated by imp:
>>
>> URL:
>> https://cgit.FreeBSD.org/src/commit/?id=5fdf01dbeef1f64f8c446561498d662702451ac1
>>
>> commit 5fdf01dbeef1f64f8c446561498d662702451ac1
>> Author:     Warner Losh <imp@FreeBSD.org>
>> AuthorDate: 2024-02-02 19:01:56 +0000
>> Commit:     Warner Losh <imp@FreeBSD.org>
>> CommitDate: 2024-02-02 19:04:57 +0000
>>
>>      Revert "stand/lua: always allow overriding with local config files"
>>
>>      This reverts commit d3d0b735571d9562812ce5b343a6e91f7a795dbe. no mail
>>      sent out, and the commit message was wrong.
>>
> 
> Due to conflicts, my pr landing script didn't rewrite the commit message.
> This
> occurred to me in the instant after I hit return on git push. My ^C was too
> late
> to prevent the deltas from being transmitted and  recorded in the repo, but
> also cut-short the commit hooks that send out the email. My apologies for
> this lack of attention to detail.

I wonder if we can fix it so that e-mails never get lost btw.  A connection
could die mid-push for various reasons.  Ideally we'd track "somewhere"
the last hash that had been sent on each branch and the commit hook would
just poke the daemon that sends e-mails and updates the last hash, but the
daemon could also just periodically poll the branches in case a poke is
missed.

-- 
John Baldwin




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5faea9f0-80f2-4d07-84e5-876ee54c1870>