Date: Mon, 7 Jul 2025 13:26:22 -0400 From: Matteo Riondato <matteo@FreeBSD.org> To: Kristof Provost <kp@FreeBSD.org> Cc: "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "dev-commits-src-all@freebsd.org" <dev-commits-src-all@FreeBSD.org>, "dev-commits-src-main@freebsd.org" <dev-commits-src-main@FreeBSD.org> Subject: Re: git: f8a8bb7bade9 - main - pfctl: Improve duplicate table name warning Message-ID: <81D328A4-8A6C-44DA-861B-D3C067986CBE@FreeBSD.org> In-Reply-To: <202507071507.567F7n8Q016403@gitrepo.freebsd.org> References: <202507071507.567F7n8Q016403@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Jul 7, 2025, at 11:07 AM, Kristof Provost <kp@FreeBSD.org> wrote: >=20 > The branch main has been updated by kp: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3Df8a8bb7bade9575c549cbc94500ba706= b712c650 >=20 > commit f8a8bb7bade9575c549cbc94500ba706b712c650 > Author: Kristof Provost <kp@FreeBSD.org> > AuthorDate: 2025-07-01 10:02:03 +0000 > Commit: Kristof Provost <kp@FreeBSD.org> > CommitDate: 2025-07-07 15:06:48 +0000 >=20 > pfctl: Improve duplicate table name warning >=20 > When creating tables inside anchors, pfctl warned about namespace > collisions with global tables, but only in certain cases and with > limited information sometimes leaving users clueless. >=20 > Deferring the check to process_tabledefs() where tables are = eventually > created, both anchor and table name are known which allows for = checking > all existing anchors. >=20 > With this, warn on all duplicates even in dry-runs (`-n') and print > quoted names so they can be copied to fix configurations right = away. >=20 > No functional change in parsing or ruleset production. Based only on the commit message, this may fix PR #262295. Thanks, Matteo
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?81D328A4-8A6C-44DA-861B-D3C067986CBE>