Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 9 Jan 2017 03:14:04 +0000 (UTC)
From:      Ngie Cooper <ngie@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r311740 - in head/usr.sbin/bsnmpd/modules: snmp_hostres snmp_mibII
Message-ID:  <201701090314.v093E49A039246@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: ngie
Date: Mon Jan  9 03:14:04 2017
New Revision: 311740
URL: https://svnweb.freebsd.org/changeset/base/311740

Log:
  Improve the smilint target in the hostres and mibII modules
  
  - Mark the smilint target .PHONY so it's always executed when requested
  - Leverage .PATH for BMIBS instead of spelling the path out longhand
    for them
  
  MFC after:	1 week

Modified:
  head/usr.sbin/bsnmpd/modules/snmp_hostres/Makefile
  head/usr.sbin/bsnmpd/modules/snmp_mibII/Makefile

Modified: head/usr.sbin/bsnmpd/modules/snmp_hostres/Makefile
==============================================================================
--- head/usr.sbin/bsnmpd/modules/snmp_hostres/Makefile	Mon Jan  9 03:08:21 2017	(r311739)
+++ head/usr.sbin/bsnmpd/modules/snmp_hostres/Makefile	Mon Jan  9 03:14:04 2017	(r311740)
@@ -76,6 +76,7 @@ LIBADD=	kvm devinfo m geom memstat
 printcap.pico: printcap.c
 	${CC} ${PICFLAG} -DPIC ${CFLAGS:C/^-W.*//} -c ${.IMPSRC} -o ${.TARGET}
 
-smilint:
+smilint: .PHONY
+smilint: ${BMIBS}
 	env SMIPATH=.:/usr/share/snmp/mibs:/usr/local/share/snmp/mibs \
-	    smilint -c /dev/null -l6 -i group-membership BEGEMOT-HOSTRES-MIB
+	    smilint -c /dev/null -l6 -i group-membership ${.ALLSRC}

Modified: head/usr.sbin/bsnmpd/modules/snmp_mibII/Makefile
==============================================================================
--- head/usr.sbin/bsnmpd/modules/snmp_mibII/Makefile	Mon Jan  9 03:08:21 2017	(r311739)
+++ head/usr.sbin/bsnmpd/modules/snmp_mibII/Makefile	Mon Jan  9 03:14:04 2017	(r311740)
@@ -22,6 +22,7 @@ BMIBS=	BEGEMOT-IP-MIB.txt BEGEMOT-MIB2-M
 
 .include <bsd.snmpmod.mk>
 
-smilint:
+smilint: .PHONY
+smilint: ${BMIBS}
 	env SMIPATH=/usr/share/snmp/mibs:/usr/local/share/snmp/mibs \
-	    smilint -c /dev/null -l6 -i group-membership ${BMIBS:C/^/${CONTRIB}\/snmp_mibII\//}
+	    smilint -c /dev/null -l6 -i group-membership ${.ALLSRC}



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201701090314.v093E49A039246>