Date: Thu, 26 Feb 2004 20:46:48 -0600 From: Peter Schultz <pmes@bis.midco.net> To: Kris Kennaway <kris@obsecurity.org> Cc: cvs-ports@FreeBSD.org Subject: Re: cvs commit: ports/graphics/xaos Makefile Message-ID: <403EAF98.7080009@bis.midco.net> In-Reply-To: <20040227015101.GA10403@xor.obsecurity.org> References: <200402251000.i1PA0nGn056196@repoman.freebsd.org> <403E0B90.9040106@bis.midco.net> <20040226203351.GB5915@xor.obsecurity.org> <403EA170.9080100@bis.midco.net> <20040227015101.GA10403@xor.obsecurity.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Kris Kennaway wrote:
> On Thu, Feb 26, 2004 at 07:46:24PM -0600, Peter Schultz wrote:
>
>
>>>>+ .if defined(WITH_THREADS)
>>>>+ CONFIGURE_ARGS+= --with-pthread=yes
>>>>+ .endif
>>>>+
>>>
>>>
>>>And does this do the right thing with PTHREAD_{CFLAGS,LIBS} on 4.x and 5.x?
>>>
>>>Kris
>>
>>I'm not sure, I copied the functionality from the textproc/libxml2
>>Makefile. I'm only assuming it "Just Works". What should I be looking
>>out for?
>
>
> Set PTHREAD_LIBS='-DNOP -lpthread' PTHREAD_CFLAGS='-DNOP2' or similar
> and verify that they're showing up correctly in the build log.
>
I'm not getting the point of this. If I `make -DWITH_THREADS' after
this patch, xaos is built and linked properly:
cc -DHAVE_SYS_PARAM_H -I/usr/local/include -pipe -O6 -fstrength-reduce
-ffast-math -fomit-frame-pointer -fforce-mem -fforce-addr -funroll-loops
-D_REENTRANT -I/usr/include/ncurses -I/usr/X11R6/include
-I/usr/local/include -I/usr/X11R6/include
-I/usr/ports/graphics/xaos/work/XaoS-3.0/src/include -L/usr/local/lib -o
/usr/ports/graphics/xaos/work/XaoS-3.0/bin/xaos lib/libui.a
lib/libengine.a lib/libutil.a lib/libfilter.a lib/libuiaa.a
lib/libuix11.a -lpng -lz -lm -laa -lncurses -lpthread
-L/usr/X11R6/lib -L/usr/X11R6/lib -lX11 -L/usr/X11R6/lib -lX11
-L/usr/local/lib -L/usr/local/lib -lXext -L/usr/X11R6/lib -lX11
What is -DNOP? Why doesn't textproc/libxml2 require this?
Pete...
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?403EAF98.7080009>