Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 5 Sep 2024 09:52:39 -0400
From:      Mark Johnston <markj@freebsd.org>
To:        John Baldwin <jhb@freebsd.org>
Cc:        src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org
Subject:   Re: git: fc12c191c087 - main - grep: Default to -p instead of -S.
Message-ID:  <Ztm3p2OJmtVA4_66@nuc>
In-Reply-To: <202409041953.484JrvPY028856@gitrepo.freebsd.org>
References:  <202409041953.484JrvPY028856@gitrepo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Sep 04, 2024 at 07:53:57PM +0000, John Baldwin wrote:
> The branch main has been updated by jhb:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=fc12c191c087b63e1204fee210ba76082ea40b96
> 
> commit fc12c191c087b63e1204fee210ba76082ea40b96
> Author:     John Baldwin <jhb@FreeBSD.org>
> AuthorDate: 2024-09-04 19:53:22 +0000
> Commit:     John Baldwin <jhb@FreeBSD.org>
> CommitDate: 2024-09-04 19:53:22 +0000
> 
>     grep: Default to -p instead of -S.
>     
>     This matches the documented behavior in the manpage as well as the
>     default behavior on macOS.

Should this get a RELNOTES entry?

>     
>     PR:             280676
>     Reported by:    Radosław Piliszek <radoslaw.piliszek@gmail.com>
>     Reviewed by:    kevans
>     MFC after:      1 week
>     Differential Revision:  https://reviews.freebsd.org/D46256
> ---
>  usr.bin/grep/grep.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/usr.bin/grep/grep.c b/usr.bin/grep/grep.c
> index 9f960f74dbb6..feaf17d7c1e1 100644
> --- a/usr.bin/grep/grep.c
> +++ b/usr.bin/grep/grep.c
> @@ -112,7 +112,7 @@ int	 binbehave = BINFILE_BIN;	/* -aIU: handling of binary files */
>  int	 filebehave = FILE_STDIO;
>  int	 devbehave = DEV_READ;		/* -D: handling of devices */
>  int	 dirbehave = DIR_READ;		/* -dRr: handling of directories */
> -int	 linkbehave = LINK_READ;	/* -OpS: handling of symlinks */
> +int	 linkbehave = LINK_SKIP;	/* -OpS: handling of symlinks */
>  
>  bool	 dexclude, dinclude;	/* --exclude-dir and --include-dir */
>  bool	 fexclude, finclude;	/* --exclude and --include */



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Ztm3p2OJmtVA4_66>