Date: Thu, 8 Oct 2020 13:24:44 +0200 From: Piotr Kubaj <pkubaj@anongoth.pl> To: Adam Weinberger <adamw@adamw.org> Cc: ports-committers <ports-committers@freebsd.org>, svn-ports-all <svn-ports-all@freebsd.org>, svn-ports-head <svn-ports-head@freebsd.org> Subject: Re: svn commit: r551634 - head/databases/postgresql13-server Message-ID: <20201008112444.GA30140@KGPE-D16> In-Reply-To: <CAP7rwci=m-0q9A7XN-MFymP_Q54G7CrzCsb907H4HisUC6%2BM5A@mail.gmail.com> References: <202010071306.097D6JOj080863@repo.freebsd.org> <CAP7rwcgpFhJB2d09XuvpOQ%2B09OPZoW%2BOXbtQTrqEp22=qJFKJA@mail.gmail.com> <20201008102448.GA35539@KGPE-D16> <CAP7rwci=m-0q9A7XN-MFymP_Q54G7CrzCsb907H4HisUC6%2BM5A@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--6c2NcOVqGQ03X4Wi Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 20-10-08 04:34:47, Adam Weinberger wrote: > On Thu, Oct 8, 2020 at 4:24 AM Piotr Kubaj <pkubaj@anongoth.pl> wrote: > > > > It was previously committed in https://svnweb.freebsd.org/ports?view=3D= revision&revision=3D527871 and it seemed to work. Or is it that just no one= noticed it? > > > > I'm trying to understand why this issue appeared and how to fix it with= out reverting to the previous (also broken) behaviour. >=20 > The problem happens because of the extra level of indirection. The > ${CHOSEN_COMPILER_TYPE} causes it to be evaluated too late, > overwriting PORT_OPTIONS. >=20 > As to why it wasn't happening before, I'm not sure. Why not just > exclude it on gcc archs instead? > OPTIONS_DEFINE=3D ... LLVM > OPTIONS_EXCLUDE_fooarch=3D LLVM That wouldn't work. There are no architectures that use base GCC on head, b= ecause base GCC was removed. So it should be excluded on 11 and 12, but it = should also be enabled on 13. So ideally, it would need to be something like BROKEN: BROKEN_FreeBSD_12_powerpc64=3D I'll look whether something like this works: OPTIONS_EXCLUDE_powerpc64=3D ${OPTIONS_EXCLUDE_powerpc64_${OSREL:R}} OPTIONS_EXCLUDE_powerpc64_12=3D LLVM >=20 > I can certainly appreciate the clever approach you're taking here, but > it's apparently too clever for options.mk. >=20 > # Adam >=20 >=20 > > On 20-10-08 04:11:05, Adam Weinberger wrote: > > > On Wed, Oct 7, 2020 at 7:06 AM Piotr Kubaj <pkubaj@freebsd.org> wrote: > > > > > > > > Author: pkubaj > > > > Date: Wed Oct 7 13:06:19 2020 > > > > New Revision: 551634 > > > > URL: https://svnweb.freebsd.org/changeset/ports/551634 > > > > > > > > Log: > > > > databases/postgresql13-server: fix build on GCC architectures > > > > > > > > Add the previously removed disabling of LLVM when it's not in bas= e. > > > > > > > > > > +OPTIONS_DEFAULT+=3D ${OPTIONS_DEFAULT_${CHOSEN_COMPILER_TYPE}} > > > > +OPTIONS_DEFAULT_clang=3D LLVM > > > > > > This forces the LLVM option on for all clang users, and prevents it > > > from ever getting turned off. Please, turn the LLVM forcing off. >=20 >=20 > --=20 > Adam Weinberger > adamw@adamw.org > https://www.adamw.org --6c2NcOVqGQ03X4Wi Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEycyIeNkkgohzsoorelmbhSCDnJ0FAl9+9vwACgkQelmbhSCD nJ2TpQ//XSedJ1TMf1TxRJdjU1P/4qPe8TwgiwFz54bZ5vyt745NWtaN+iBRWplh +vz5Z3s+nRidq6zlRZnqBF4KIbGVOyY0GQu43NOheHMgft1RuQdTKSKOYrmtI4VQ myxQ5K2XJHUA7z+Gdgbn8DPOy4uCaKp34b2cbVs/FBKgndF6hDN1uxIOEHCY1L47 pKR1AHedyhm17Mvd0m1Dq517xIjoGxQTmQ7HYNNp0F8JmrgtIpe89TBEpcYexLMq ztaoZZ6XvoEOhS2m+shZfpq/YqS/7LtUj49WLpt4f3afg4qESu8ZJQjtAnADjcfy kX7sJig2Lo7j7a2Ob0NXuzyMLa8yb8uV3SVX5IlWfXC7v+Lqr5u4YkYMquqCVjaI TiFGtkMIKDQlh+2FE2ccGiM6TR2t+HbSPzSfExa+h6+v4mHeGDOisuFyV0s6ghy7 EUvIVJ1iOh21uHOFNRao9ECQCpxUAn8IBi0q7BditpnShv6PhU7cHk3Tg1QmqRgz SI9zdtP8W/6E0utEqtLXMNjmuQ3qTXLFdKqJBy8P30+ocmPyHSonEpzfHQaE0LGb 1NztmIdJgkqWNU3aLK1gvnUhRmpcvlt2xhwWOtbwjT2onHKZuSM5sy2yIKeR5dEP IPnjwdw+vRe6p0cTzMeK2xhYPpsXE1srXpq+ukv4BeTBYhtsuaw= =0mct -----END PGP SIGNATURE----- --6c2NcOVqGQ03X4Wi--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20201008112444.GA30140>